Page MenuHomeSolus
Differential D6802

Initial inclusion of perl-class-method-modifiers
ClosedPublic
Actions

Authored by tomocafe on Jul 26 2019, 4:36 AM.
Tags
None
Referenced Files
F11009204: D6802.id18269.diff
Wed, Aug 2, 12:49 PM
F10969767: D6802.diff
Thu, Jul 20, 11:45 PM
F10943326: D6802.id.diff
Fri, Jul 14, 5:43 PM
F10827239: D6802.diff
Jun 4 2023, 4:53 AM
F10804287: D6802.id18388.diff
May 29 2023, 3:28 PM
F10803438: D6802.id16309.diff
May 29 2023, 11:49 AM
F10802483: D6802.id18269.diff
May 29 2023, 7:23 AM
F10801503: D6802.id16964.diff
May 29 2023, 2:25 AM
View All 12 Files
Subscribers
DataDrake
JoshStrobl

Details

Reviewers
JoshStrobl
DataDrake
Group Reviewers
Triage Team
Commits
R4856:1717c90447b2: Initial inclusion of perl-class-method-modifiers
Summary

Add perl dependency of cloc

Test Plan

See cloc test plan

Diff Detail

Repository
R4856 perl-class-method-modifiers
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomocafe created this revision.Jul 26 2019, 4:36 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptJul 26 2019, 4:36 AM
tomocafe requested review of this revision.Jul 26 2019, 4:36 AM
tomocafe added a child revision: D6804: Initial inclusion of perl-moo.Jul 26 2019, 1:51 PM
tomocafe retitled this revision from Initial inclusion of perl-class-method-modifiers Needed for cloc, see T8163 to Initial inclusion of perl-class-method-modifiers.Jul 26 2019, 5:31 PM
JoshStrobl requested changes to this revision.Aug 30 2019, 11:09 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
13

Should also have this as a rundep.

This revision now requires changes to proceed.Aug 30 2019, 11:09 AM
tomocafe updated this revision to Diff 16964.Aug 31 2019, 2:56 AM
tomocafe marked an inline comment as done.

Fix rundeps

JoshStrobl accepted this revision.Sep 3 2019, 3:55 PM
This comment was removed by JoshStrobl.
This revision is now accepted and ready to land.Sep 3 2019, 3:55 PM
JoshStrobl requested changes to this revision.Sep 3 2019, 3:57 PM

Correction: See remark on perl-moo about commit amending. Docs available at https://getsol.us/articles/packaging/submitting-a-package/en/#updating-a-patch-that-needs-changes

This revision now requires changes to proceed.Sep 3 2019, 3:57 PM
tomocafe updated this revision to Diff 18269.Nov 10 2019, 9:51 PM

Fix differential

DataDrake accepted this revision.Nov 18 2019, 5:30 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Nov 18 2019, 6:19 AM
Closed by commit R4856:1717c90447b2: Initial inclusion of perl-class-method-modifiers (authored by tomocafe, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.
DataDrake added a commit: R4856:1717c90447b2: Initial inclusion of perl-class-method-modifiers.

Revision Contents
Changeset List

PathSize
1 line
20 lines
36 lines

Diff 18388

View Options

Makefile

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.