Page MenuHomeSolus

update paramiko to 2.6.0
ClosedPublic

Authored by hashhsah on Jul 25 2019, 7:36 PM.

Details

Summary

update paramiko to 2.6.0

Changelog at http://www.paramiko.org/changelog.html

Depends on D6799

Test Plan

passes all unit tests

Diff Detail

Repository
R2637 python-paramiko
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

hashhsah created this revision.Jul 25 2019, 7:36 PM
hashhsah requested review of this revision.Jul 25 2019, 7:36 PM
hashhsah edited the summary of this revision. (Show Details)Jul 25 2019, 7:44 PM
hashhsah updated this revision to Diff 17392.Sep 27 2019, 5:39 PM

Rebuild and tested against python-cryptography (D6539)

JoshStrobl requested changes to this revision.Oct 1 2019, 1:44 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
files/paramiko-2.6.0-drop-pytest-relaxed.patch
50–53

This is a pretty clear indication the patch failed to apply because git is indicating rejects.

This revision now requires changes to proceed.Oct 1 2019, 1:44 PM
hashhsah updated this revision to Diff 17494.Oct 1 2019, 2:28 PM

The patch actually applies cleanly. Remove .rej/.orig files that implied otherwise.

+ patch -t -E --no-backup-if-mismatch -f -p1
patching file tests/test_client.py
[Build] setup successful
[Build] Running step: build
DataDrake accepted this revision.Mon, Nov 18, 5:31 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Nov 18, 6:13 AM
This revision was automatically updated to reflect the committed changes.