Page MenuHomeSolus

update python-cryptography to 2.7
AbandonedPublic

Authored by hashhsah on Jul 25 2019, 7:32 PM.

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

update python-cryptography to 2.7, needed by paramiko

Changes lot at https://github.com/pyca/cryptography/blob/master/CHANGELOG.rst

Test Plan

paramiko builds and pass all tests after upgrading python-cryptography

Diff Detail

Repository
R2569 python-cryptography
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

hashhsah created this revision.Jul 25 2019, 7:32 PM
hashhsah requested review of this revision.Jul 25 2019, 7:32 PM
Jacalz added a subscriber: Jacalz.EditedJul 26 2019, 7:18 AM

I already had D6539 open for the upgrade, but this (and my revision) requires a lot of testing and I don’t currently have the time for that. If you want to do the testing, I will abandon my revision in favor of yours at the moment :)

Please see the requested changes by @JoshStrobl in that task for more info on the testing.

@Jacalz Sorry I didn't search properly before i submit this patch. I was updating paramiko, which requires the new version of python-cryptography.
I only have experience with paramiko, and never used the packages JoshStrobl mentioned. Perhaps @JoshStrobl wants to coordinate the testing effort.

Actually I think I should abandon mine. You patch came first. I'm in no better position to do the testing. My patch is incorrect. hell, I forgot to quote the version number, again.

hashhsah abandoned this revision.Jul 29 2019, 4:42 PM

abandoning this patch in favor of D6539

I will make sure to do the testing in my revision when I get the time and get back from my vacation.