Differential D6791

Update Atom to 1.39.0
ClosedPublic
Actions

Authored by JamesLee on Jul 23 2019, 6:28 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Maniphest Tasks

T8174: Update brackets to 1.14

Commits

R394:2403eadf4559: Update Atom to 1.39.0

Summary

Updated Atom to the latest stable release 1.39.0.

Changelog:

atom/atom - Enhance performance of window resizing to provide speed and responsiveness comparable to native desktop applications racing_car
atom/atom - Upgrade to Electron 3.1.10
atom/find-and-replace - Add config option to use ripgrep for scanning files for much faster searches in large projects racehorse
atom/find-and-replace - Handle multiline results on the find and replace UI
atom/find-and-replace - Support multiple selections when "Only In Selection" option is enabled
atom/fuzzy-finder - Enable fuzzy finder's new fast mode by default rocket
atom/language-python - Tokenize *args and **kwargs the same as other parameters (tree-sitter)
atom/language-typescript - Use new TSX-aware TreeSitter grammar
atom/tree-view - Copy files on drop if control is pressed

Complete changelog available here.

Test Plan

Installed and edited a few files with everything working as expected.
Checked that the correct version information is displayed in the about page.

Diff Detail

Repository

R394 atom

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

JamesLee created this revision.Jul 23 2019, 6:28 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJul 23 2019, 6:28 PM

JamesLee requested review of this revision.Jul 23 2019, 6:28 PM

I have basically been doing the latest nine updates of atom in the repo and began doing so after being poorly updated for a couple releases, but you can have it this time...

EDIT: I really don’t need to sound rude, just trying to get the point across. It is fine for me and especially good since I am on vacation and couldn’t get the update out anyway :)

In D6791#107300, @Jacalz wrote:

I have basically been doing the latest nine updates of atom in the repo and began doing so after being poorly updated for a couple releases, but you can have it this time...

EDIT: I really don’t need to sound rude, just trying to get the point across. It is fine for me and especially good since I am on vacation and couldn’t get the update out anyway :)

It's all good, I didn't think you were being rude. I'm just watching lots of repositories on GitHub and get emails fairly frequently so when I get the time, I try to do my bit. You are welcome to commandeer the differential if you would like to take over the process from here.

JamesLee edited the summary of this revision. (Show Details)Jul 23 2019, 7:48 PM

JamesLee added a task: T8174: Update brackets to 1.14.

JamesLee edited the summary of this revision. (Show Details)

JamesLee mentioned this in T8174: Update brackets to 1.14.Jul 23 2019, 7:51 PM

Thanks, I know the feeling and it’s totally fine for me. I have no need to commandeer this diff, you have made a great effort already. I also appreciate that you switched back to the release tarballs as I forgot to switch back last time (there was a release a while back where the tarball was borked).

I couldn’t have done the diff right now anyway, so it’s all right :)

Jacalz awarded a token.Jul 23 2019, 8:12 PM

In D6791#107300, @Jacalz wrote:

I have basically been doing the latest nine updates of atom in the repo and began doing so after being poorly updated for a couple releases, but you can have it this time...

EDIT: I really don’t need to sound rude, just trying to get the point across. It is fine for me and especially good since I am on vacation and couldn’t get the update out anyway :)

*cough* In my defense, I quite literally can't build it on any of my modern machines, only my really old Intel hardware that is chilling in a closet. It consistently fails, otherwise I would've continued updating it.

Anyways, patch looks good to me. Thanks for the update!

This revision is now accepted and ready to land.Jul 24 2019, 6:14 AM

Closed by commit R394:2403eadf4559: Update Atom to 1.39.0 (authored by JamesLee, committed by JoshStrobl). · Explain WhyJul 24 2019, 6:15 AM

This revision was automatically updated to reflect the committed changes.