Differential D6779

Update mpg123 to 1.25.11
ClosedPublic
Actions

Authored by kyrios123 on Jul 20 2019, 3:06 PM.

Tags

None

Referenced Files

	F11004693: D6779.diff
	Tue, Aug 1, 3:03 AM

	F10967381: D6779.id.diff
	Thu, Jul 20, 9:09 AM

	F10873322: D6779.id16271.diff
	Jun 19 2023, 11:24 AM

	F10872543: D6779.id16322.diff
	Jun 19 2023, 1:08 AM

	F10867021: D6779.diff
	Jun 17 2023, 6:30 PM

	F10815145: D6779.diff
	May 31 2023, 7:14 PM

	F10777860: D6779.id16322.diff
	May 24 2023, 1:54 AM

	F10744424: D6779.id.diff
	May 15 2023, 12:45 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

R2106:6a34271c21ef: Update mpg123 to 1.25.11

Summary

Fix out-of-bounds reads in ID3 parser for unsynced frames.
Fix out-of-bounds read for RVA2 frames with non-delimited identifier.
Fix implementation-defined parsing of RVA2 values.
Fix undefined parsing of APE header for skipping. Also prevent endless loop on premature end of supposed APE header.
Fix some syntax to make pedantic compiler happy.

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

mpg123 wave.mp3
checked against Audacious

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kyrios123 created this revision.Jul 20 2019, 3:06 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJul 20 2019, 3:06 PM

kyrios123 requested review of this revision.Jul 20 2019, 3:06 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 26 2019, 10:32 AM

Closed by commit R2106:6a34271c21ef: Update mpg123 to 1.25.11 (authored by kyrios123, committed by JoshStrobl). · Explain WhyJul 26 2019, 10:33 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

14 lines

pspec_x86_64.xml

62 lines

Diff 16271

package.yml

Loading...

pspec_x86_64.xml

Loading...