Page MenuHomeSolus

Initial inclusion of raylib library
ClosedPublic

Authored by chax on Jul 17 2019, 1:29 PM.

Details

Summary

Initial inclusion of raylib library
Fixes T4545
Depends on D6760

Test Plan
  • successfully built library with solbuild
  • installed resulting raylib and raylib-devel eopkg packages
  • cloned raylib repo locally and built example games from games/ dir
  • games successfully built and ran
  • built more complex game like skully_escape and enjoyed playing it

Diff Detail

Repository
R4809 raylib
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chax created this revision.Jul 17 2019, 1:29 PM
chax requested review of this revision.Jul 17 2019, 1:29 PM
Girtablulu requested changes to this revision.Jul 17 2019, 2:12 PM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
pspec_x86_64.xml
40

static libs are baaaad :)

This revision now requires changes to proceed.Jul 17 2019, 2:12 PM
chax updated this revision to Diff 16227.Jul 17 2019, 2:16 PM

Removed static lib

JoshStrobl requested changes to this revision.Aug 29 2019, 5:51 PM
JoshStrobl added subscribers: SolarLune, JoshStrobl.

Need a better test plan than just being successfully built. Maybe @SolarLune can chime in.

package.yml
7

Not a valid spdx 3.0 license identifier. This specific one should be zlib-acknowledgement

8

Should be programming.library

This revision now requires changes to proceed.Aug 29 2019, 5:51 PM
chax updated this revision to Diff 16939.Aug 30 2019, 12:19 AM
chax edited the test plan for this revision. (Show Details)

Updated package.yml with correct licence and component, added more detailed testplan

JoshStrobl accepted this revision.Aug 30 2019, 11:16 AM

That is a much more thorough test plan, thank you very much for that. It is genuinely appreciated.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 30 2019, 11:17 AM
This revision was automatically updated to reflect the committed changes.