Page MenuHomeSolus

Update glfw to release 3.3
ClosedPublic

Authored by chax on Jul 17 2019, 1:25 PM.

Details

Summary

Update glfw to release 3.3
Switched to ninja build.
Changelog can be found here

Test Plan

Successfully built library with solbuild.

Diff Detail

Repository
R925 glfw
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chax created this revision.Jul 17 2019, 1:25 PM
chax requested review of this revision.Jul 17 2019, 1:25 PM
JoshStrobl requested changes to this revision.Jul 18 2019, 6:02 PM
JoshStrobl added a subscriber: JoshStrobl.

For the packages removed from the abi_used_libs, we should add them as rundeps. Per glfw's changelog for 3.3:

GLFW now loads all X11 extension libraries at initialization. The only X11 library you need to link against is libX11. The header files for the extension libraries are still required for compilation.
Existing projects and makefiles that link GLFW directly against the extension libraries should still build correctly but will add these libraries as load-time dependencies.

There was some ABI changes and dropped functionality (like for deadzones) but given nothing actually uses this, I'm not concerned.

This revision now requires changes to proceed.Jul 18 2019, 6:02 PM
chax updated this revision to Diff 16262.Jul 19 2019, 9:43 AM

Added rundeps which are removed from abi_used_libs

JoshStrobl requested changes to this revision.Jul 26 2019, 10:26 AM
JoshStrobl added inline comments.
package.yml
18–21

Erm, no.

  1. You should be using the explicit package name for the main package.
  2. You should be using the -devel package name for the devel package.
This revision now requires changes to proceed.Jul 26 2019, 10:26 AM
chax added a comment.Jul 26 2019, 10:32 AM

Aha, I'm still learning. I will fix this.

chax updated this revision to Diff 16332.Jul 26 2019, 2:43 PM

Updated rundeps as suggested.

JoshStrobl accepted this revision.Jul 31 2019, 5:09 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 31 2019, 5:09 AM
This revision was automatically updated to reflect the committed changes.