Details
- Reviewers
DataDrake - Commits
- R3727:12cd69f8383f: Initial commit of PulseView, required for T4063
Verify that PulseView launches and can connect to and log data
from supported signal analyzer hardware. I have tested extensively with the
OpenBench Logic Sniffer using these packages on Unstable.
Diff Detail
- Repository
- R3727 pulseview
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Component change, otherwise it LGTM.
| package.yml | ||
|---|---|---|
| 8 | I would put this in office.scientific | |
Looks like I missed redundant builddeps in my initial review. These should be the last changes needed. Thanks!
| package.yml | ||
|---|---|---|
| 17 | This is the same package as Qt5Widgets and can be left out. | |
| 18 | This is the same package as Qt5Widgets and can be left out. | |
| 19 | This is a dependency of Qt5Widgets and can be left out. | |
Adding comment regarding proposed removal of Qt5Svg dependency.
| package.yml | ||
|---|---|---|
| 19 | Removal of Qt5Svg as an explicit dependency breaks the build: Could not find a package configuration file provided by "Qt5Svg" with any of the following names: Qt5SvgConfig.cmake qt5svg-config.cmake Add the installation prefix of "Qt5Svg" to CMAKE_PREFIX_PATH or set "Qt5Svg_DIR" to a directory containing one of the above files. If "Qt5Svg" provides a separate development package or SDK, be sure it has been installed. | |
pkgconfig(Qt5Svg) is the only qt5 builddep required (it pulls in qt5-base-devel which has all the other pkgconfigs). So remove the Qt5Widgets one
You may also need to rundep qt5-svg seen as it doesn't link against it (or it won't display the svg icons correctly). You can test it via sudo eopkg rm --ignore-dependency qt5-svg to see if it looks bad without it.
| package.yml | ||
|---|---|---|
| 18 | I'll defer to @sunnyflunk on this one. We can drop the Qt5Widgets dep and then you're all set on this one. Thanks! | |