Page MenuHomeSolus

Initial commit of Cutter
ClosedPublic

Authored by aleksvor on Jul 15 2019, 4:16 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T8093: Cutter
Commits
R4774:8ca347ee377e: Initial commit of Cutter
Summary

Initial commit of Cutter. Resolves T8093.

Test Plan
  1. Disassembled /bin/ls.
  2. Checked the graph output of main function.
  3. Checked hexdump of the file.
  4. Exported graph in graphviz file and visualized it with dot.
  5. Generated pseudocode for main function.

Diff Detail

Repository
R4774 cutter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aleksvor created this revision.Jul 15 2019, 4:16 PM
aleksvor requested review of this revision.Jul 15 2019, 4:16 PM
JoshStrobl requested changes to this revision.Jul 18 2019, 6:28 PM
JoshStrobl added a subscriber: JoshStrobl.

Nice work, you even added the MAINTAINERS.md file! Much appreciated in that.

package.yml
16

Should be above the libr pkgconfig (0-9, then A-Z, then a-z).

19

Newline for this is probably unnecessary given it's just a single option.

pspec_x86_64.xml
24

Let's go ahead and get cutter symlinked to Cutter as well. I can already predict a new task being opened up with someone trying to open it from the terminal, without autocomplete, and failing. Should just be ln -s /usr/bin/Cutter $installdir/usr/bin/cutter

This revision now requires changes to proceed.Jul 18 2019, 6:28 PM
aleksvor updated this revision to Diff 16245.Jul 18 2019, 7:02 PM
  1. Reordered builddeps case-sensitively (will do the same for other packages that I maintain).
  2. Removed unnecessary newline.
  3. Created /usr/bin/cutter symlink.
JoshStrobl accepted this revision.Jul 18 2019, 7:15 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 18 2019, 7:15 PM
This revision was automatically updated to reflect the committed changes.