Page MenuHomeSolus

Update python-fasteners to 0.15 & drop python2 support
AbandonedPublic

Authored by kyrios123 on Jul 15 2019, 1:04 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

List of changes available here
Depends on D6746

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Tested with duplicity

Diff Detail

Repository
R3804 python-fasteners
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

kyrios123 created this revision.Jul 15 2019, 1:04 PM
kyrios123 requested review of this revision.Jul 15 2019, 1:04 PM
JoshStrobl accepted this revision.Jul 18 2019, 7:18 PM
This revision is now accepted and ready to land.Jul 18 2019, 7:18 PM

I want to take advantage of the fact that this patch hasn't been commited to say we could include thi patch https://github.com/harlowja/fasteners/commit/2ffefdc226e7f634ee636548eaac9ce470a7696c.patch
This would also allow us to deprecate python-monotonic: python-fasteners is its only revdep and now that python-fasteners is Python3, there's no more need of the monotonic module.

kyrios123 added a comment.EditedAug 13 2019, 11:00 AM

I want to take advantage of the fact that this patch hasn't been commited to say we could include thi patch https://github.com/harlowja/fasteners/commit/2ffefdc226e7f634ee636548eaac9ce470a7696c.patch
This would also allow us to deprecate python-monotonic: python-fasteners is its only revdep and now that python-fasteners is Python3, there's no more need of the monotonic module.

Just for your info, this is part of the duplicity 8.x stack which I put on hold because I only noticed after submitting the patch that it was still a development version (shame on me).
I haven't abandonned these patches because I hope version 8 will be promoted to stable soon so be warned that this won't be landed immediately.

livingsilver94 added a comment.EditedAug 13 2019, 11:18 AM

I see.
Speaking about the mycroft upgrade, mycroft is written in Python3, which means it needs python-fasteners and, in turn, python-monotonic in Python3. Are you then OK with me abandoning your python-monotonic patch and submitting another patch to have python-monotonic in both Python2 and 3?

kyrios123 abandoned this revision.Fri, Aug 23, 4:02 PM