Page MenuHomeSolus
Differential D6741

Update gamehub to 0.14.2-1
ClosedPublic
Actions

Authored by kyrios123 on Jul 14 2019, 6:34 AM.
Tags
None
Referenced Files
F11053005: D6741.diff
Thu, Aug 10, 10:30 PM
F11031413: D6741.id16193.diff
Wed, Aug 9, 12:51 PM
F11018512: D6741.id16192.diff
Sun, Aug 6, 12:43 PM
F11016786: D6741.id16193.diff
Sat, Aug 5, 8:05 PM
F10994544: D6741.id.diff
Tue, Jul 25, 11:27 PM
F10991877: D6741.id16212.diff
Tue, Jul 25, 3:48 AM
F10991872: D6741.id16193.diff
Tue, Jul 25, 3:45 AM
F10991871: D6741.id16192.diff
Tue, Jul 25, 3:45 AM
View All 34 Files
Subscribers
Girtablulu
JoshStrobl
tkashkin

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T8141: Update gamehub to 0.14.2-1
Commits
R4766:d6611034f5d5: Update gamehub to 0.14.2-1
Summary
  • Game details view improvements
  • Add IGDB request quota warning
  • Prioritize user games over installed games over uninstalled games when all sources are shown
  • Fix slashes for DOSBox data_dirs
  • Add 'Open screenshots directory' action for Steam games
  • DOSBox improvements
  • Add timeout after exiting game to prevent immediate restart due to keypresses
  • Add DOS exe/bat/com support to DOSBox CompatTool
  • Allow to run executables in DOSBox without configs
  • Fix Humble authentication page styles
  • Fix segfault in GameListRow.update_style
  • Games list grouping options
  • Additional games list style options
  • Fix tags toggling
  • Fix segfault when installing/downloading multiple games
  • Translations update

Closes T8141

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Launch application, login to GOG and Humble Store, browse my libraries, launch a game

Diff Detail

Repository
R4766 gamehub
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kyrios123 created this revision.Jul 14 2019, 6:34 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptJul 14 2019, 6:34 AM
kyrios123 requested review of this revision.Jul 14 2019, 6:34 AM
tkashkin added a subscriber: tkashkin.Jul 14 2019, 4:25 PM

@kyrios123 Please set git_commit variable to be55ac0a45229a8e76ed7a0c6c6ab31521adab4b

Girtablulu added a subscriber: Girtablulu.Jul 14 2019, 4:32 PM

@tkashkin the shasum depends on the tar file not on the git commit

tkashkin added a comment.Jul 14 2019, 4:35 PM

@Girtablulu There is git_commit variable in setup section which is passed to meson. It is shown in the app and is part of displayed version string.

kyrios123 updated this revision to Diff 16190.Jul 14 2019, 4:57 PM

Remove git_option in meson build because it's a PITA and I would often forget to update them which may cause useless confusion.
We use tarballs and version numbers are a thing.

tkashkin added a comment.Jul 14 2019, 5:03 PM

@kyrios123 Ok, remove git_commit, it's not that important. It would be great if at least master branch was still passed.

setup      : |
    %meson_configure -Dgit_branch=master
kyrios123 updated this revision to Diff 16191.Jul 14 2019, 5:32 PM

Add back meson option git_branch=master on request of the appliation developer

kyrios123 updated this revision to Diff 16192.Jul 14 2019, 5:33 PM

.. and remove useless git_commit variable

JoshStrobl requested changes to this revision.Jul 14 2019, 10:24 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
18

-Dgit_branch not -D git_branch

This revision now requires changes to proceed.Jul 14 2019, 10:24 PM
kyrios123 updated this revision to Diff 16193.Jul 15 2019, 6:02 AM

remove space

JoshStrobl accepted this revision.Jul 15 2019, 2:16 PM
This revision is now accepted and ready to land.Jul 15 2019, 2:16 PM
Closed by commit R4766:d6611034f5d5: Update gamehub to 0.14.2-1 (authored by kyrios123). · Explain WhyJul 15 2019, 5:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
12 lines
6 lines

Diff 16212

View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.