Details
Details
- Reviewers
DataDrake - Commits
- R3725:2fc8b654d9e7: Initial commit of libsigrok, required for T4063
If sigrok-cli and PulseView are able to connect to supported
signal analyzers then libsigrok is functioning properly.
Diff Detail
Diff Detail
- Repository
- R3725 libsigrok
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
See inline comments.
| package.yml | ||
|---|---|---|
| 12 | These should be listed in alphabetical order, with pkgconfig entries before the rest. | |
| 15 | Should be pulled in by libftdi1, so no need to list it. | |
| 20 | Included in system.devel so not needed. | |
| pspec_x86_64.xml | ||
| 10 | Should be programming.library | |
| 23 | Should be in /usr/lib64/udev/rules.d | |
| 41 | Static libs should be disabled unless required for other packages. | |
Comment Actions
Changed component, cleaned up builddeps, removed static libraries and changed udev rules destination per review comments.