Page MenuHomeSolus

Build all breeze theme stuff inside one package
ClosedPublic

Authored by Girtablulu on Jul 6 2019, 5:31 PM.

Details

Summary

Build all breeze theme stuff inside one package

Test Plan

Everything still works as expected

Diff Detail

Repository
R450 breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Girtablulu created this revision.Jul 6 2019, 5:31 PM
Girtablulu requested review of this revision.Jul 6 2019, 5:31 PM
JoshStrobl requested changes to this revision.Jul 10 2019, 1:36 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
10–11

You need to remove | otherwise it'll treat the entire section as a block of text. Notice the pspec description for breeze.

This revision now requires changes to proceed.Jul 10 2019, 1:36 PM
Girtablulu updated this revision to Diff 16111.Jul 10 2019, 1:42 PM

Fix description

JoshStrobl accepted this revision.Jul 10 2019, 1:43 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 10 2019, 1:43 PM
This revision was automatically updated to reflect the committed changes.
Jacalz added a subscriber: Jacalz.Jul 10 2019, 7:13 PM

Just FIY, it seems that this commit breaks the breeze cursor setting for Budgie. This happened to me, after updating I needed to reconfigure the cursor in budgie-desktop-settings. My guess is that it might happen the same for other users on different DEs.

Just FIY, it seems that this commit breaks the breeze cursor setting for Budgie. This happened to me, after updating I needed to reconfigure the cursor in budgie-desktop-settings. My guess is that it might happen the same for other users on different DEs.

Ignoring the fact you should have created a separate task (seriously people need to stop commenting on closed diffs and commits), it is likely related to your icon theme cache. @Girtablulu I'd probably advise we ship a symlink for /usr/share/icons/breeze-cursor that points to /usr/share/icons/breeze_cursor and have that in the breeze-cursor-theme package. Might prevent breakage.

@Jacalz I pushed a fix, it works for my budgie notebook. the next time open a Task because I don't give any attention to comments inside closed diffs/tasks

Jacalz added a comment.EditedJul 11 2019, 6:57 AM

@Jacalz I pushed a fix, it works for my budgie notebook. the next time open a Task because I don't give any attention to comments inside closed diffs/tasks

I am sorry, it was late and I wasn’t totally clear in my head. Work has been hammering me totally and made me extremely tired lately. Should be back to normal next week...