Page MenuHomeSolus

Update python-spyder-kernels to 0.5.1
ClosedPublic

Authored by maverick1 on Jul 6 2019, 12:06 PM.

Details

Summary

Update python-spyder-kernels to 0.5.1

Changes

  • Set Matplotlib backend to inline for kernels started in a terminal.
  • Handle option sent from Spyder to show/hide cmd windows generated by the subprocess module.
Test Plan

Ran some machine learning codes in spyder3 which is its reverse depencency

Diff Detail

Repository
R4473 python-spyder-kernels
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

maverick1 created this revision.Jul 6 2019, 12:06 PM
maverick1 requested review of this revision.Jul 6 2019, 12:06 PM
JoshStrobl requested changes to this revision.Jul 11 2019, 3:17 PM
JoshStrobl added a subscriber: JoshStrobl.

Does spyder (not spyder3) need to be updated against this?

This revision now requires changes to proceed.Jul 11 2019, 3:17 PM

Yes, the requirement needs it to be updated!

Does spyder (not spyder3) need to be updated against this?

I am so sorry Josh, I mistakenly meant for spyder. Spyder needn't be built against this.

maverick1 updated this revision to Diff 16613.Aug 12 2019, 3:51 AM

Bump to 0.5.1

maverick1 retitled this revision from Update python-spyder-kernels to 0.5.0 to Update python-spyder-kernels to 0.5.1.Aug 12 2019, 4:02 AM
maverick1 edited the summary of this revision. (Show Details)
JoshStrobl accepted this revision.Aug 29 2019, 5:36 PM

LGTM, thanks!

This revision is now accepted and ready to land.Aug 29 2019, 5:36 PM
This revision was automatically updated to reflect the committed changes.