Page MenuHomeSolus

Update flask to 1.1.1
ClosedPublic

Authored by maverick1 on Jul 6 2019, 10:54 AM.

Details

Summary

Update flask to 1.1.1 Depends on D6688

Changes

  • The flask.json_available flag was added back for compatibility with some extensions. It will raise a deprecation warning when used, and will be removed in version 2.0.0.
  • Bump minimum Werkzeug version to >= 0.15.
  • Drop support for Python 3.4.
  • Error handlers for InternalServerError or 500 will always be passed an instance of InternalServerError.
  • The flask run command no longer fails if Python is not built with SSL support. Using the --cert option will show an appropriate error message.
  • Show a better error message when the view return type is not supported.
  • Blueprints have a cli Click group like app.cli. CLI commands registered with a blueprint will be available as a group under the flask command.
  • Allow returning a dictionary from a view function. Similar to how returning a string will produce a text/html response, returning a dict will call jsonify to produce a application/json response.
  • Add an --extra-files option to the flask run CLI command to specify extra files that will trigger the reloader on change.
  • Signaling support has a stub for the connect_via method when the Blinker library is not installed.
  • Support static_url_path that ends with a forward slash.
  • Support empty static_folder without requiring setting an empty static_url_path as well.
  • The flask command entry point is simplified to take advantage of Werkzeug 0.15's better reloader support.
  • Flask's JSONMixin for the request and response wrappers was moved into Werkzeug. Use Werkzeug's version with Flask-specific support.
  • Using built-in RequestContext, unprintable Unicode characters in Host header will result in a HTTP 400 response and not HTTP 500 as previously.
Test Plan

Ran a flask server with blueprints registered.

Diff Detail

Repository
R765 flask
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

maverick1 created this revision.Jul 6 2019, 10:54 AM
maverick1 requested review of this revision.Jul 6 2019, 10:54 AM

Removed check because D6688 should be available first for it to check.

Removed check because D6688 should be available first for it to check.

Don't remove the checks, instead add the keyword Depends on D6688 in the summary to create a dependency (see packaging doc on the help center). This way we know D6688 is a prerequisite for landing this package.

kyrios123 requested changes to this revision.Jul 6 2019, 1:49 PM
This revision now requires changes to proceed.Jul 6 2019, 1:49 PM

I will edit this as soon as D6688 gets landed. I have added D6688 as a parent to this revision.

maverick1 updated this revision to Diff 16100.Jul 9 2019, 11:47 AM

Update flask to 1.1.1

maverick1 retitled this revision from Update flask to 1.1.0 to Update flask to 1.1.1.Jul 9 2019, 11:48 AM
maverick1 edited the summary of this revision. (Show Details)
maverick1 edited the summary of this revision. (Show Details)
JoshStrobl requested changes to this revision.Jul 18 2019, 7:22 PM
JoshStrobl added a subscriber: JoshStrobl.

No, you should use solbuild local repositories and building for this. We have documentation on the Help Center.

This revision now requires changes to proceed.Jul 18 2019, 7:22 PM
maverick1 updated this revision to Diff 16265.Jul 19 2019, 11:40 AM

Used solbuild local repo!

maverick1 edited the summary of this revision. (Show Details)Jul 19 2019, 11:41 AM

It has been long since this patch has been submitted. May I know the cause of its deferral and the other patches that I have submitted?

JoshStrobl accepted this revision.Aug 29 2019, 5:32 PM

LGTM, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Aug 29 2019, 5:34 PM
Closed by commit R765:892b8aa195de: Update flask to 1.1.1 (authored by maverick1, committed by JoshStrobl). · Explain Why
This revision was automatically updated to reflect the committed changes.