Page MenuHomeSolus

Run cups-pk-helper service under its own daemon user account. Fixes T7453.
ClosedPublic

Authored by tomocafe on Sat, Jul 6, 7:05 AM.

Details

Summary

Run cups-pk-helper service under its own daemon user account. Fixes T7453.

Test Plan

If no printer available, create a dummy one with lpadmin -p myprinter -E -v ipp://myprinter.local/ipp/print (per man lpadmin). WLOG, print something to myprinter. Open the "printers" part of gnome-control-center (Alt+F2 > Printers). Observe the button 1 job and click it. In the myprinter - Active Jobs window, find the submitted job and press the trash can to cancel the job. With this fix, it should successfully cancel. Previous behavior resulted in nothing happening.

Diff Detail

Repository
R577 cups-pk-helper
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tomocafe requested review of this revision.Sat, Jul 6, 7:05 AM
tomocafe created this revision.
Jacalz added a subscriber: Jacalz.Sat, Jul 6, 7:12 AM
Jacalz added inline comments.
package.yml
17

You can use %reconfigure --with-daemon-user=cups-pk-helper instead of running autoreconf

tomocafe updated this revision to Diff 16068.Sat, Jul 6, 6:17 PM

Change autoreconf to reconfigure per @Jacalz

davidjharder added inline comments.
package.yml
6

This should be updated to an SPDX identifier.

tomocafe updated this revision to Diff 16071.Sat, Jul 6, 9:01 PM
tomocafe marked an inline comment as done.
tomocafe edited the test plan for this revision. (Show Details)

Update license to valid SPDX identifier: GPL-2.0-or-later

JoshStrobl requested changes to this revision.Thu, Jul 11, 2:57 PM

LGTM otherwise. Thanks for looking into this and providing a fix, it's much appreciated!

package.yml
21

Should be -Dm00644

This revision now requires changes to proceed.Thu, Jul 11, 2:57 PM
tomocafe updated this revision to Diff 16172.Fri, Jul 12, 4:03 PM
tomocafe marked an inline comment as done.
tomocafe edited the test plan for this revision. (Show Details)

Fix install arguments per @JoshStrobl

JoshStrobl accepted this revision.Fri, Jul 12, 4:04 PM

LGTM, thanks!

This revision is now accepted and ready to land.Fri, Jul 12, 4:04 PM
This revision was automatically updated to reflect the committed changes.