Page MenuHomeSolus
Differential D6686

Initial commit of double-conversion
ClosedPublic
Actions

Authored by alecbcs on Jul 5 2019, 10:27 PM.
Tags
None
Referenced Files
F11036490: D6686.id16072.diff
Wed, Aug 9, 7:23 PM
F11036489: D6686.id16058.diff
Wed, Aug 9, 7:23 PM
F11036488: D6686.id16266.diff
Wed, Aug 9, 7:23 PM
F11036487: D6686.id16467.diff
Wed, Aug 9, 7:23 PM
F11036486: D6686.id.diff
Wed, Aug 9, 7:23 PM
F11026887: D6686.diff
Wed, Aug 9, 3:07 AM
F10970357: D6686.id16467.diff
Fri, Jul 21, 2:16 AM
F10929059: D6686.id.diff
Jul 11 2023, 3:35 AM
View All 18 Files
Subscribers
aleksvor
JoshStrobl

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R4781:3ac937f4f5a5: Initial commit of double-conversion
Summary

Inital commit of double-conversion which is a dependency of OpenSCAD 2019.05 D6685.

Test Plan

Used to compile OpenSCAD sucessfully.

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

alecbcs created this revision.Jul 5 2019, 10:27 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptJul 5 2019, 10:27 PM
alecbcs requested review of this revision.Jul 5 2019, 10:27 PM
aleksvor added a subscriber: aleksvor.Jul 6 2019, 6:42 AM

According to their readme, you can build it as a shared library using -DBUILD_SHARED_LIBS=ON.

alecbcs updated this revision to Diff 16072.Jul 6 2019, 11:21 PM

Fixed build to package shared library object. Thanks @aleksvor!

alecbcs added a child revision: D6685: Update OpenSCAD to 2019.05.Jul 6 2019, 11:23 PM
JoshStrobl requested changes to this revision.Jul 18 2019, 7:24 PM
JoshStrobl added a subscriber: JoshStrobl.

You did not correctly submit this patch. You should be amending your commit, this should all be an initial commit (the first in master). https://getsol.us/articles/packaging/submitting-a-package/en/#updating-a-patch-that-needs-changes

This revision now requires changes to proceed.Jul 18 2019, 7:24 PM
alecbcs updated this revision to Diff 16266.Jul 19 2019, 8:29 PM

Fixed git history

JoshStrobl accepted this revision.Aug 4 2019, 4:47 PM

LGTM, thanks!

This revision is now accepted and ready to land.Aug 4 2019, 4:47 PM
Closed by commit R4781:3ac937f4f5a5: Initial commit of double-conversion (authored by alecbcs, committed by JoshStrobl). · Explain WhyAug 4 2019, 4:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
1 line
48 lines
4 lines
16 lines
61 lines

Diff 16266

View Options

Makefile

Loading...
View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.