Page MenuHomeSolus

Initial commit of double-conversion
ClosedPublic

Authored by alecbcs on Jul 5 2019, 10:27 PM.

Details

Summary

Inital commit of double-conversion which is a dependency of OpenSCAD 2019.05 D6685.

Test Plan

Used to compile OpenSCAD sucessfully.

Diff Detail

Repository
R4781 double-conversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alecbcs created this revision.Jul 5 2019, 10:27 PM
alecbcs requested review of this revision.Jul 5 2019, 10:27 PM

According to their readme, you can build it as a shared library using -DBUILD_SHARED_LIBS=ON.

alecbcs updated this revision to Diff 16072.Jul 6 2019, 11:21 PM

Fixed build to package shared library object. Thanks @aleksvor!

JoshStrobl requested changes to this revision.Jul 18 2019, 7:24 PM
JoshStrobl added a subscriber: JoshStrobl.

You did not correctly submit this patch. You should be amending your commit, this should all be an initial commit (the first in master). https://getsol.us/articles/packaging/submitting-a-package/en/#updating-a-patch-that-needs-changes

This revision now requires changes to proceed.Jul 18 2019, 7:24 PM
alecbcs updated this revision to Diff 16266.Jul 19 2019, 8:29 PM

Fixed git history

JoshStrobl accepted this revision.Aug 4 2019, 4:47 PM

LGTM, thanks!

This revision is now accepted and ready to land.Aug 4 2019, 4:47 PM
This revision was automatically updated to reflect the committed changes.