Page MenuHomeSolus

Initial commit of double-conversion
Needs ReviewPublic

Authored by alecbcs on Fri, Jul 5, 10:27 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

Inital commit of double-conversion which is a dependency of OpenSCAD 2019.05 D6685.

Test Plan

Used to compile OpenSCAD sucessfully.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
alecbcs created this revision.Fri, Jul 5, 10:27 PM
alecbcs requested review of this revision.Fri, Jul 5, 10:27 PM

According to their readme, you can build it as a shared library using -DBUILD_SHARED_LIBS=ON.

alecbcs updated this revision to Diff 16072.Sat, Jul 6, 11:21 PM

Fixed build to package shared library object. Thanks @aleksvor!

JoshStrobl requested changes to this revision.Thu, Jul 18, 7:24 PM
JoshStrobl added a subscriber: JoshStrobl.

You did not correctly submit this patch. You should be amending your commit, this should all be an initial commit (the first in master). https://getsol.us/articles/packaging/submitting-a-package/en/#updating-a-patch-that-needs-changes

This revision now requires changes to proceed.Thu, Jul 18, 7:24 PM
alecbcs updated this revision to Diff 16266.Fri, Jul 19, 8:29 PM

Fixed git history