Page MenuHomeSolus

Update to terraform 0.12.3
ClosedPublic

Authored by sbattali on Jul 5 2019, 4:03 AM.

Details

Summary

Enhancements:

  • config: add GCS source support for modules
  • command/format: Reduce extra whitespaces & new lines
  • backend/s3: Support for chaining assume IAM role from AWS

Bug Fixes:

  • configs: Can now use references like tags["foo"] in ignore_changes
  • configs: Fix panic on missing value for version attribute in provider blocks.
  • lang/funcs: Fix merge panic on null values. Now will give an error if null
  • backend/remote: Fix "Conflict" error
  • backend/s3: Fix AWS shared cfg file not using environment/ECS credentials

More verbose changelog (filling gaps between 0.11.13->0.12.3) here

Resolves T8040

Test Plan
  • Cloned terraform example config to local folder
  • run terraform init
  • change cfg files
  • run terraform plan to see changes
  • run terraform apply to apply changes
  • log into cloud service provider and verify changes propagate
  • run terraform destroy to remove and verify removed properly

Diff Detail

Repository
R4354 terraform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sbattali created this revision.Jul 5 2019, 4:03 AM
sbattali requested review of this revision.Jul 5 2019, 4:03 AM

Let me know if there's anything else I need to do/change. This is my first time updating a package and would appreciate any help!

sbattali edited the summary of this revision. (Show Details)Jul 5 2019, 6:54 PM
JoshStrobl requested changes to this revision.Jul 11 2019, 3:47 PM
JoshStrobl added a subscriber: JoshStrobl.

Changelog needs to be cleaned up:

  1. 80 column is the devil. That needs to be fixed.
  2. No indentation is needed for level 0 / root list items, only 1 space for level 1, 2 for level 2, etc.
  3. "Since this package hasn't been updated in a couple updates, I have just listed the updates for the most recent version." - Not needed, can be removed.
  4. "Summary" header can be removed. "Enhancements" should be a level 0 / root list item, the enhancements themselves level 1. Same goes for bug fixes.

I would also appreciate if you could add the following file to the repository (not the package itself) as MAINTAINERS.md:

This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository.

- Sam Battalio
  - IRC: REPLACEME
  - Email: sambattalio99@gmail.com

Change REPLACEME with your IRC nickname for freenode. If you do not have one, feel free to remove the list item.


Thanks for picking up maintainership of this! The patch itself looks good!

This revision now requires changes to proceed.Jul 11 2019, 3:47 PM
sbattali updated this revision to Diff 16184.Jul 13 2019, 6:03 PM

Updated to meet specs from reviewer.

sbattali edited the summary of this revision. (Show Details)Jul 13 2019, 6:15 PM
sbattali edited the summary of this revision. (Show Details)Jul 13 2019, 6:27 PM

Think i cleaned up what was needed. Had a hard time with adding linebreaks in the list in remarkup so I just shortened the notes for each bullet point. Thanks for the help!

JoshStrobl accepted this revision.Jul 15 2019, 2:23 PM

LGTM, thanks for the patch!

This revision is now accepted and ready to land.Jul 15 2019, 2:23 PM
This revision was automatically updated to reflect the committed changes.