Page MenuHomeSolus

Initial commit of networkx fixes T4114
AbandonedPublic

Authored by padraig on Jul 20 2017, 5:14 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

padraig created this revision.Jul 20 2017, 5:14 PM
padraig updated this revision to Diff 2030.Aug 31 2017, 11:37 AM

Updated the license

The license was missing the "-Clause" part

padraig updated this revision to Diff 2098.Sep 5 2017, 9:57 AM

Updated pspec after rebuilding with correct license identifier

Why are you building for both Python 2 and 3?

Why are you building for both Python 2 and 3?

Every python package I've used so far in Solus runs for both Python 2 and 3 after installing the eopkg so I assumed it was standard to build for both?
Are you suggesting I have different builds for 2 and 3?

padraig updated this revision to Diff 2920.Oct 10 2017, 9:47 PM

Package.yml updates as version 2.0 of networkx has been released

JoshStrobl requested changes to this revision.Nov 18 2017, 10:27 PM
JoshStrobl added a subscriber: JoshStrobl.

Every python package I've used so far in Solus runs for both Python 2 and 3 after installing the eopkg so I assumed it was standard to build for both?

Quite the contrary, we only enable python 2 or python 3 based on what we actually need. So is python 2 support needed? Is python 3? If one of them isn't, they shouldn't be included.

This revision now requires changes to proceed.Nov 18 2017, 10:27 PM

! In D668#22472, @JoshStrobl wrote:
So is python 2 support needed?

In principle I would like if I could just use Python 3, however, I can't get some packages in working Python 3 (in Solus libboost for example). Therefore I alternate between using 2 and 3 which is annoying but has been the way for a lot of people who do scientific programming for a good few years now due to some legacy libraries. Because of this I would like support for both.

All the other python packages I use in Solus so far support both, the ones that spring to mind which I use regularly are numpy, scipy, matplotlib, pandas, scikit-learn, pygraphviz (the last of which I submitted the package.yml). As a result I just assumed it was standard to build for both. I presume the ones above support both as they are more commonly used in either?