Page MenuHomeSolus

New release of android-tools 29.0.1
ClosedPublic

Authored by chax on Wed, Jul 3, 11:44 PM.

Details

Summary
  • Switched to main google source
  • Patched few sources so they can build on Solus
  • Included few additional tools (apart from: adb and fastboot):
    • avbtool
    • e2fsdroid
    • ext2simg
    • mkbootimg
    • mke2fs.android
Test Plan

Built, installed and issued few adb and fastboot commands

Diff Detail

Repository
R4737 android-tools
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chax created this revision.Wed, Jul 3, 11:44 PM
chax requested review of this revision.Wed, Jul 3, 11:44 PM
chax added a comment.Wed, Jul 3, 11:45 PM

Following discussion from T8111, i updated android-tools and built them directly from google sources.

JoshStrobl requested changes to this revision.Thu, Jul 4, 11:34 AM
JoshStrobl added a subscriber: JoshStrobl.

Good start!

package.yml
26

Should use the pkgconfig

28

Should use the pkgconfig

30

Not needed yet since python is still in system.base. Can't be moved out until we rewrite the package manager.

31

Not needed. Not only is this marked as a rundep as noted with the abi_used_libs, but it is part of system.base.

32

Do we still need to be in $sources after the for loop given you're operating on items in $workdir after that? If not, should wrap the for loop in: pushd $sources and pop respectively.

39

Is there any way to disable SELinux? That isn't something we support nor want to.

43

Empty line is unnecessary

52โ€“53

Have you tried removing the first install call and just having -Dm00755 on the second one? -D will create all the leading components of DEST, not sure if it'll operate well alongside -t to automatically append the source argument onto the end of DEST but maybe worth a try *shrug*

This revision now requires changes to proceed.Thu, Jul 4, 11:34 AM
chax updated this revision to Diff 16016.Thu, Jul 4, 1:51 PM

Fixed after review remarks

chax added a comment.Thu, Jul 4, 2:00 PM

Unfortunately i couldn't disable selinux because they use it in source and there is no way to disable it via some build flag, but i figured out that we don't need their selinux source, so i just added libselinux and libsepol as pkgconfig builddeps and linked them correctly during build.
I cleaned up a bit package.yml, so now it looks tidier.

JoshStrobl requested changes to this revision.Thu, Jul 11, 3:04 PM

Looks much better than the initial patch, nice work cleaning it up. Very minor thing I raised in this review, once it is resolved I don't see a reason for this to not be added ๐Ÿ‘

package.yml
23โ€“26

These should always be listed before static package names.

This revision now requires changes to proceed.Thu, Jul 11, 3:04 PM
chax updated this revision to Diff 16150.Thu, Jul 11, 3:34 PM

Reordered builddeps so that pkgconfig packages are listed first

JoshStrobl accepted this revision.Fri, Jul 12, 1:49 PM

LGTM, thanks for the significant update to this!

This revision is now accepted and ready to land.Fri, Jul 12, 1:49 PM
This revision was automatically updated to reflect the committed changes.
This comment was removed by Staudey.