Page MenuHomeSolus

Update mame to 0.211
ClosedPublic

Authored by livingsilver94 on Jul 2 2019, 4:12 PM.

Details

Summary

Changelog:

Test Plan

Played Car Polo successfully.

Diff Detail

Repository
R3922 mame
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

livingsilver94 created this revision.Jul 2 2019, 4:12 PM
livingsilver94 requested review of this revision.Jul 2 2019, 4:12 PM
This comment was removed by livingsilver94.
livingsilver94 retitled this revision from Update mame to 0.207 to Update mame to 0.211.Jul 2 2019, 4:26 PM

I did a mess with git ๐Ÿ˜ wait while I fix.

Nah I'll work on it tomorrow. This patch is doomed ๐Ÿ‘ป

Will it work now?

Yes it does. Phew.

livingsilver94 edited the summary of this revision. (Show Details)Jul 3 2019, 9:28 AM

Another mame release is out. mame has a monthly release cadence.
This is not the first time I see my mame patch ignored/deferred and I have to say it's not pleasant to see my work not being appreciated. Now please tell me: if you can't afford to sustain a monthly release, it's all good, but tell me clearly.

Another mame release is out. mame has a monthly release cadence.
This is not the first time I see my mame patch ignored/deferred and I have to say it's not pleasant to see my work not being appreciated. Now please tell me: if you can't afford to sustain a monthly release, it's all good, but tell me clearly.

It's not about you or about your work... I got some patches from 2017 that haven't been reviewed and that will be abandoned the day someone will do it since it would be outdated anyway (example: D1638)
My 2 cents, when you get such a thing go on IRC the day before or the day after a sync and ask if your patch can be landed. That's what I do when something is important to me.

JoshStrobl accepted this revision.Aug 8 2019, 12:15 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Aug 8 2019, 12:15 PM
This revision was automatically updated to reflect the committed changes.