Initial inclusion of Arduino IDE
ClosedPublic
Actions

Authored by chax on Jul 1 2019, 3:28 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Maniphest Tasks

T210: Arduino IDE

Commits

R4769:974ea1d4c4a4: Initial inclusion of Arduino IDE

Summary

Initial inclusion of Arduino IDE
Fixes T210

Test Plan

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

chax requested review of this revision.Jul 1 2019, 3:28 PM

Good work on this, I'm sure this was a real pain to package!

package.yml
13	Should probably put this in `programming.ide`
14	*Arduino
64–74	It saddens me that this is quite literally their suggested method instead of...ya know...supporting Go Modules :\
84	Should be 00755
93	Should be 00755
100–102	Should be 00755
pspec_x86_64.xml
765	Probably not needed.
894	Probably not needed.

This revision now requires changes to proceed.Jul 2 2019, 5:26 PM

@JoshStrobl thanks for the review, i will fix this soon.

Fixed review comments

Fix typo

LGTM, nice work!

This revision is now accepted and ready to land.Jul 5 2019, 2:48 PM

This revision was automatically updated to reflect the committed changes.

		Path
A	M	Makefile (1 line)
A	M	abi_used_libs (5 lines)
A	M	files/0001-use-system-toolchain.patch (29 lines)
A	M	package.yml (106 lines)
A	M	pspec_x86_64.xml (907 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15921	4b825dc		Jul 1 2019, 3:28 PM	★	★
Diff 2	15995	4b825dc	Fixed review comments	Jul 3 2019, 8:12 AM	★	★
Diff 3	15996	4b825dc	Fix typo	Jul 3 2019, 8:16 AM	★	★
Diff 4	16037	cd1e53b	R4769:974ea1d4c4a49e28c34e86c83234405f241e180a	Jul 5 2019, 2:49 PM	★	★