Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Maniphest Tasks
- T4053: MariaDB provides mytop, but dependencies aren't met
T4337: mariadb: Missing mysql_install_db - Commits
- R2019:55b9e320c2ea: Update mariadb to 10.4.6
mariadb_first_install works if /var/db/mysql does not exist.
sudo systemctl start mariadb nmap -sT localhost # Port 3306/tcp is open
# Create /etc/mysql/my.cnf.d/test.cnf with # [client-server] # port = 4567 sudo systemctl restart mariadb nmap -sT localhost # Port 4567/tcp is open, 3306/tcp is not
mysqld --print-defaults correctly shows flags manually set in /usr/share/defaults/mysql/my.cnf.d/server.cnf.
Diff Detail
- Repository
- R2019 mariadb
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
I think we should remove the service file for multiple instances of mariadb (which is also not patched to run mariadb_first_install). What's your opinion?
Which service files are you talking about specifically? systemd has a ExecStartPre key for systemd services that we should preferably use for the services to have it run before ExecStart
| pspec_x86_64.xml | ||
|---|---|---|
| 861–862 | @JoshStrobl this one. This service is not patched and it's meant to support multiple mariadb instances simultaneously. | |
| pspec_x86_64.xml | ||
|---|---|---|
| 861–862 | Ah. Yea I'd nuke it. | |
| package.yml | ||
|---|---|---|
| 81–82 | Honest question, is anybody actually going to ever use mysqltest? It's used for running test cases, seems to be more targeted for those that actually develop MariaDB than anything else. I'd almost say we could nuke this entirely and if possible, disable the compilation of it. | |
| 149 | Should be 00644 | |
| package.yml | ||
|---|---|---|
| 81–82 | IDK, I just kept the things as they were, but yeah according to this article the -test suite is for MariaDB development. I'll delete it. | |
| 149 | Ah OK. Many dirs inside /etc are with 755, I copied from them. I'll fix it. | |
| package.yml | ||
|---|---|---|
| 149 | You are correct, dirs need to be 755 as they cannot be opened without the executable bit | |
| package.yml | ||
|---|---|---|
| 36 | Have you tested to ensure building perl-dbd-mysql against all the mariadb bits in a local doesn't cause a circular dependency issue? Not sure if it'll want a specific release or release >= one at build time otherwise. | |
@JoshStrobl I gave a brief look at perl-dbd-mysql source code and it doesn't want a specific version of mariadb. I think there's no possibility for a circular dep to exist. Also, mytop calls perl-dbd-mysql at runtime, it's not linked.