Page MenuHomeSolus

Update mariadb to 10.4.6
ClosedPublic

Authored by livingsilver94 on Jul 1 2019, 9:12 AM.

Details

Summary

Changelog:
Release notes available here starting from version 10.3.14.

Package changes:

  • Move mariadb_first_install into mariadb-server package
  • Make MariaDB stateless
  • Minor fixes to package descriptions
  • Remove mariadb-test child package

Fixes T4337. Fixes T4053.

Test Plan

mariadb_first_install works if /var/db/mysql does not exist.

sudo systemctl start mariadb
nmap -sT localhost
# Port 3306/tcp is open
# Create /etc/mysql/my.cnf.d/test.cnf with
# [client-server]
# port = 4567
sudo systemctl restart mariadb
nmap -sT localhost
# Port 4567/tcp is open, 3306/tcp is not

mysqld --print-defaults correctly shows flags manually set in /usr/share/defaults/mysql/my.cnf.d/server.cnf.

Diff Detail

Repository
R2019 mariadb
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

livingsilver94 created this revision.Jul 1 2019, 9:12 AM
livingsilver94 requested review of this revision.Jul 1 2019, 9:12 AM
livingsilver94 edited the test plan for this revision. (Show Details)Jul 1 2019, 9:12 AM
livingsilver94 edited the test plan for this revision. (Show Details)
livingsilver94 edited the test plan for this revision. (Show Details)Jul 1 2019, 9:17 AM

No AppArmor profiles for now. And they were in the wrong directory anyway.

livingsilver94 edited the summary of this revision. (Show Details)Jul 1 2019, 9:55 AM
livingsilver94 retitled this revision from Make mariadb stateless and move mariadb_first_install into mariadb-server to Make mariadb stateless; move mariadb_first_install into mariadb-server.
livingsilver94 edited the summary of this revision. (Show Details)
JoshStrobl requested changes to this revision.Jul 2 2019, 5:29 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
5

We should probably get this updated to 10.4.6-GA while we're at it.

94–121

I get the whole idea with why you aligned them, but honestly 4 spaces probably would be sufficient.

This revision now requires changes to proceed.Jul 2 2019, 5:29 PM
livingsilver94 marked an inline comment as done.Jul 2 2019, 7:10 PM

Update to 10.4.6 (I hate you Josh >.>)

livingsilver94 retitled this revision from Make mariadb stateless; move mariadb_first_install into mariadb-server to Update mariadb to 10.4.6.Jul 2 2019, 10:05 PM
livingsilver94 edited the summary of this revision. (Show Details)
livingsilver94 marked an inline comment as done.

Remove useless whitespace edit for the patch file

Make sure to read from /usr/share/defaults/mysql/my.cnf.d; restore old patch

livingsilver94 edited the test plan for this revision. (Show Details)Jul 3 2019, 10:07 PM

I think we should remove the service file for multiple instances of mariadb (which is also not patched to run mariadb_first_install). What's your opinion?

I think we should remove the service file for multiple instances of mariadb (which is also not patched to run mariadb_first_install). What's your opinion?

Which service files are you talking about specifically? systemd has a ExecStartPre key for systemd services that we should preferably use for the services to have it run before ExecStart

livingsilver94 added inline comments.Jul 11 2019, 3:03 PM
pspec_x86_64.xml
861–862

@JoshStrobl this one. This service is not patched and it's meant to support multiple mariadb instances simultaneously.

JoshStrobl added inline comments.Jul 11 2019, 3:25 PM
pspec_x86_64.xml
861–862

Ah. Yea I'd nuke it.

Remove multi-instances service

livingsilver94 marked an inline comment as done.Jul 11 2019, 5:10 PM
JoshStrobl requested changes to this revision.Aug 8 2019, 12:14 PM
JoshStrobl added inline comments.
package.yml
81–82

Honest question, is anybody actually going to ever use mysqltest? It's used for running test cases, seems to be more targeted for those that actually develop MariaDB than anything else. I'd almost say we could nuke this entirely and if possible, disable the compilation of it.

149

Should be 00644

This revision now requires changes to proceed.Aug 8 2019, 12:14 PM
livingsilver94 added inline comments.Aug 8 2019, 12:21 PM
package.yml
81–82

IDK, I just kept the things as they were, but yeah according to this article the -test suite is for MariaDB development. I'll delete it.

149

Ah OK. Many dirs inside /etc are with 755, I copied from them. I'll fix it.

sunnyflunk added inline comments.
package.yml
149

You are correct, dirs need to be 755 as they cannot be opened without the executable bit

Remove test suite

Forgot some bits

Add rundeps for mytop

livingsilver94 edited the summary of this revision. (Show Details)Aug 9 2019, 12:14 PM
JoshStrobl added inline comments.Thu, Aug 29, 12:59 PM
package.yml
36

Have you tested to ensure building perl-dbd-mysql against all the mariadb bits in a local doesn't cause a circular dependency issue? Not sure if it'll want a specific release or release >= one at build time otherwise.

@JoshStrobl I gave a brief look at perl-dbd-mysql source code and it doesn't want a specific version of mariadb. I think there's no possibility for a circular dep to exist. Also, mytop calls perl-dbd-mysql at runtime, it's not linked.

JoshStrobl accepted this revision.Tue, Sep 3, 4:03 PM

Well, only one way to find out.

This revision is now accepted and ready to land.Tue, Sep 3, 4:03 PM
This revision was automatically updated to reflect the committed changes.