Update mailspring to 1.6.2 and build from source
ClosedPublic
Actions

Authored by xulongwu4 on Jun 28 2019, 2:27 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

R3879:112b187b938d: Update mailspring to 1.6.2 and build from source

Summary

Update mailspring to 1.6.2 and build from source

Summarized changelog:

Mailspring now allows you to RSVP to calendar events directly from your inbox. Messages with .ics attachments or text/calendar mime-parts are displayed in a nice expanded format.
A new menu option, "Copy Mailbox Permalink", allows you to generate a mailspring:// URL for a thread. Clicking this link from another application opens the thread in Mailspring.
The composer is faster, more reliable, and uses significantly less RAM over time thanks to a new version of the SlateJS text editor. You can also drag and drop selected text and drag/copy/paste inline images.
Select-all and copy paste of email message contents now works reliably in all cases.

Full changelog can be found here.

Test Plan

Connected to my gmail account and received emails.

Diff Detail

Repository

R3879 mailspring

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

xulongwu4 created this revision.Jun 28 2019, 2:27 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJun 28 2019, 2:27 PM

xulongwu4 requested review of this revision.Jun 28 2019, 2:27 PM

JoshStrobl requested changes to this revision.Jun 28 2019, 2:32 PM

JoshStrobl edited the summary of this revision. (Show Details)

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
51	ls can be removed. The art of debugging during packaging, eh? :D

This revision now requires changes to proceed.Jun 28 2019, 2:34 PM

Remove debug command

xulongwu4 marked an inline comment as done.Jun 28 2019, 2:57 PM

xulongwu4 added inline comments.

package.yml
51	Yeah my bad :)

Use git commit --amend to append commits

Could you do me a favor and run mailspring --help to see if there are any important mailspring commands (like to launch to compose a new message)? Just wanting to see if this can be another opportunity to add desktop actions per T7289

In D6625#104365, @JoshStrobl wrote:

Could you do me a favor and run mailspring --help to see if there are any important mailspring commands (like to launch to compose a new message)? Just wanting to see if this can be another opportunity to add desktop actions per T7289

@JoshStrobl This is the output of mailspring --help:

Usage: mailspring [options]

Run Mailspring: The open source extensible email client

mailspring --dev to start the client in dev mode.

mailspring --test to run unit tests.

Options:
  -d, --dev                Run in development mode.                                                                                     [boolean]
  -t, --test               Run the specified specs and exit with error code on failures.                                                [boolean]
  --safe                   Do not load packages from the settings `packages` or `dev/packages` folders.                                 [boolean]
  -h, --help               Print this usage message.                                                                                    [boolean]
  -l, --log-file           Log all test output to file.                                                                                 [string]
  -c, --config-dir-path    Override the path to the Mailspring configuration directory                                                  [string]
  -s, --spec-directory     Override the directory from which to run package specs                                                       [string]
  -f, --spec-file-pattern  Override the default file regex to determine which tests should run (defaults to "-spec.(js|jsx|es6|es)$" )  [string]
  -v, --version            Print the version.                                                                                           [boolean]
  -b, --background         Start Mailspring in the background                                                                           [boolean]

Right, so it doesn't appear they provide any CLI flags for launching composers and the like. That's a shame, but thank you for testing. Patch looks good to me!

This revision is now accepted and ready to land.Jun 28 2019, 3:36 PM

Closed by commit R3879:112b187b938d: Update mailspring to 1.6.2 and build from source (authored by Your Name <you@example.com>, committed by JoshStrobl). · Explain WhyJun 28 2019, 3:36 PM

This revision was automatically updated to reflect the committed changes.