Page MenuHomeSolus

Initial commit of gocryptfs
ClosedPublic

Authored by r3r57 on Jun 19 2019, 11:44 AM.

Details

Summary

Initial commit of gocryptfs (resolves T8066).

Test Plan

Installed and tested:

  • initialize and mount gocryptfs directory
  • add several files and unmount
  • files are encrypted as expected
  • inspect encrypted files and gocryptfs.conf with gocryptfs-xray to get additional information and extract masterkey
  • remount directory and view/edit files which are properly decrypted

Also tested whole procedure with SiriKali (GUI for gocryptfs i.a.). I have gocryptfs running since two days installed through this package and use it without issues.

Diff Detail

Repository
R4772 gocryptfs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

r3r57 created this revision.Jun 19 2019, 11:44 AM
r3r57 requested review of this revision.Jun 19 2019, 11:44 AM
r3r57 updated this revision to Diff 15707.Jun 19 2019, 11:47 AM
r3r57 edited the summary of this revision. (Show Details)

Reformat summary

r3r57 updated this revision to Diff 15708.Jun 19 2019, 11:50 AM
r3r57 edited the summary of this revision. (Show Details)

Reformat summary again (copy/paste markdown broke formatting)

r3r57 updated this revision to Diff 15709.Jun 19 2019, 11:52 AM
r3r57 edited the summary of this revision. (Show Details)

Reformat summary (should be fine now)

r3r57 updated this revision to Diff 15710.Jun 19 2019, 11:53 AM
r3r57 edited the summary of this revision. (Show Details)

Reformat summary (last try)

Initial commit descriptions do not typically have changelogs. Usually just Initial commit of <package>.

If you add Fixes T8066 or Resolves T8066 in the description then the corresponding task can be closed automatically when this patch it accepted.

r3r57 updated this revision to Diff 15714.Jun 19 2019, 7:33 PM
r3r57 retitled this revision from Initial commit to Initial commit of gocryptfs.
r3r57 edited the summary of this revision. (Show Details)

Apply davidjharder's suggestions for initial patch submission.

r3r57 added a comment.Jun 19 2019, 7:36 PM

Initial commit descriptions do not typically have changelogs. Usually just Initial commit of <package>.
If you add Fixes T8066 or Resolves T8066 in the description then the corresponding task can be closed automatically when this patch it accepted.

This makes totally sense. Thank you very much, I applied your suggestions.

JoshStrobl requested changes to this revision.Jun 27 2019, 2:27 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
19–32

While you won't be saving any lines, it'll be cleaner if you use our environment step, so you'd have something like the following:

environment      : |
    export GOPATH=$workdir

And then remove the export calls from the other steps.

This revision now requires changes to proceed.Jun 27 2019, 2:27 PM
r3r57 updated this revision to Diff 16013.Jul 4 2019, 7:21 AM

Move 'export' call to 'environment' step.

r3r57 updated this revision to Diff 16014.Jul 4 2019, 7:25 AM

Remove redundant 'export' call in 'build' step.

r3r57 marked an inline comment as done.Jul 4 2019, 7:25 AM
JoshStrobl requested changes to this revision.Jul 11 2019, 3:06 PM
JoshStrobl added inline comments.
package.yml
19

Did you actually test this? It needs to be a step like setup, build, and install (so : |).

This revision now requires changes to proceed.Jul 11 2019, 3:06 PM
r3r57 added inline comments.Jul 11 2019, 8:03 PM
package.yml
19

Of course, I would not have submitted another revision without testing it before :)
Actually it's valid YAML and will be interpreted as environment: export GOPATH=$workdir.
But this was not on purpose. I simply forgot to add the | and will correct this.

r3r57 updated this revision to Diff 16160.Jul 11 2019, 8:12 PM

Make environment a literal block as intended

r3r57 marked 2 inline comments as done.Jul 11 2019, 8:12 PM
JoshStrobl accepted this revision.Jul 12 2019, 1:51 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 12 2019, 1:51 PM
This revision was automatically updated to reflect the committed changes.