Page MenuHomeSolus

Update python-cryptography to 2.7
ClosedPublic

Authored by Jacalz on Jun 17 2019, 4:20 PM.

Details

Summary

Full changelog can be found here.

Test Plan
  • Check that I could download torrent file using deluge.
  • Verified that new svtplay-dl version could download episodes.
  • Verified that the online wallpaper fetcher in variety works.

Diff Detail

Repository
R2569 python-cryptography
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Jacalz created this revision.Jun 17 2019, 4:20 PM
Jacalz requested review of this revision.Jun 17 2019, 4:20 PM
JoshStrobl requested changes to this revision.Jul 2 2019, 5:54 PM
JoshStrobl added a subscriber: JoshStrobl.

While I do acknowledge that a significant portion of the changes are related to introducing support for various functions specifically for OpenSSL 1.1.x, I'd like to see more tests / test coverage being performed against this package, given how much uses this.

Things I'd also like to see tested:

  • gajim: This by proxy tests python-nbxmpp.
  • variety and its online wallpaper fetching: this should validate python-requests, which requires python-urllib3, which requires python-cryptography
This revision now requires changes to proceed.Jul 2 2019, 5:54 PM
Jacalz edited the test plan for this revision. (Show Details)Aug 17 2019, 7:51 AM

I have successfully tested variety against this version and there aren't any noticeable issues observed from my part. I tried to test gajim, but I couldn't get it to connect to any server at all, not even with the old version of this package. Could anyone with that know gajim help with testing of the proxy using this version of python-cryptography?

JoshStrobl accepted this revision.Aug 29 2019, 3:09 PM
This revision is now accepted and ready to land.Aug 29 2019, 3:09 PM
This revision was automatically updated to reflect the committed changes.