Page MenuHomeSolus

Initial commit of SiriKali
ClosedPublic

Authored by r3r57 on Jun 17 2019, 9:45 AM.

Details

Summary

Initial commit of SiriKali (resolves T6349).

Test Plan

Installed and tested with gocryptfs, encfs, and cryfs.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

r3r57 created this revision.Jun 17 2019, 9:45 AM
r3r57 requested review of this revision.Jun 17 2019, 9:45 AM
davidjharder added inline comments.
package.yml
12

builddeps should be in alphabetical order.

Girtablulu requested changes to this revision.Jun 17 2019, 1:32 PM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
1

lower case

7

should be on the same line as license, we make new lines if we have more then one

13

and you should use the pkgconfig(), you can find them via

eopkg info qt5-base-devel [ in this case pkgconfig(Qt5Core) ]

This revision now requires changes to proceed.Jun 17 2019, 1:32 PM
r3r57 updated this revision to Diff 15684.Jun 17 2019, 4:29 PM

Revise package.yml

  • change name to lowercase
  • use pkgconfig() where possible
  • sort builddeps in alphabetically
r3r57 marked 4 inline comments as done.Jun 18 2019, 1:26 PM
r3r57 added inline comments.
package.yml
21

remove -j$(proc)

xulongwu4 added inline comments.Jun 18 2019, 2:19 PM
package.yml
19

The flags CMAKE_INSTALL_PREFIX and CMAKE_BUILD_TYPE are defined by the %cmake macro. You can remove them here.

r3r57 updated this revision to Diff 15700.Jun 18 2019, 7:27 PM

Revise package.yml

  • remove redundant cmake/make flags
r3r57 marked 2 inline comments as done.Jun 18 2019, 7:29 PM
r3r57 updated this revision to Diff 15716.Jun 19 2019, 7:41 PM
r3r57 retitled this revision from Initial commit to Initial commit of SiriKali.
r3r57 edited the summary of this revision. (Show Details)
r3r57 added a task: T6349: SiriKali.

Apply davidjharder's suggestions for initial patch submission.

r3r57 updated this revision to Diff 15765.Jun 22 2019, 3:58 PM

Add patch to fix potential crash when using internal wallet (see https://github.com/mhogomchungu/lxqt_wallet/issues/7).

The patch itself looks good, can we get this updated to 1.3.9? Also maybe @Girtablulu can review things he marked for changes *cough*

r3r57 added a comment.Aug 30 2019, 7:10 AM

The patch itself looks good, can we get this updated to 1.3.9?

I will update the patch within the next week but everyone is welcome to do so earlier.

r3r57 updated this revision to Diff 17001.Sep 4 2019, 1:08 PM

Update SiriKali to 1.3.9 for initial inclusion (remove obsolete patch)

DataDrake accepted this revision.Dec 22 2019, 5:02 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Dec 22 2019, 5:06 AM
This revision was automatically updated to reflect the committed changes.