Page MenuHomeSolus

Update rcm to 1.3.3
Needs ReviewPublic

Authored by EbonJaeger on Wed, Jun 12, 6:58 PM.

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

This changes the source URL back to the thoughtbot.github.io/rcm URL since the Github releases downloads are missing vital files like the configure file. If this is a problem, I'll see what I can do to make the Github release work.

Changelog:

  • Feature: Expand ~ in DOTFILES_DIR
  • Feature: Expand ~ in DOTFILES_DIR hooks
  • BUGFIX: Fix cd for paths beginning with hyphen (-)
  • BUGFIX: Fallback the LOGNAME from whoami
  • BUGFIX: Directories with spaces in rcup(1)
  • BUGFIX: Use =, not ==, in test(1)
  • Documentation improvements
Test Plan

Built and installed the package, created a new dotfile folder, listed added dotfiles, and verified the symlink results work correctly.

Diff Detail

Repository
R2791 rcm
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
EbonJaeger created this revision.Wed, Jun 12, 6:58 PM
EbonJaeger requested review of this revision.Wed, Jun 12, 6:58 PM
Jacalz added a subscriber: Jacalz.Wed, Jun 12, 7:01 PM
Jacalz added inline comments.
package.yml
5

As a tip, it's better to use links directly from the GitHub repository. You will find releases at the releases page (here in this case) and you should grab the tar.gz file from the given release. So you'd use this link instead 🙂

Reworking to make this build using the Github release. Have to package a Ruby gem.

EbonJaeger added a comment.EditedWed, Jun 12, 10:58 PM

Update: Using the %autogen macro with the Github release source causes it to hang at a certain part in the configure step. Have yet to figure out why.

*EDIT: I think it's because it tries to use the git contributors to generate the manpage contributor list. The sources, of course, don't contain that information. Running the autogen script manually from a git clone of the repo works just fine. And the package.yml as it currently is in this diff works fine since all of that stuff is pre-generated in that source link. Any pointers as to what I can do here?

EbonJaeger retitled this revision from Update to 1.3.3 to Update rcm to 1.3.3.Wed, Jun 12, 11:41 PM
In D6501#102617, @Gnat008 wrote:

Update: Using the %autogen macro with the Github release source causes it to hang at a certain part in the configure step. Have yet to figure out why.

*EDIT: I think it's because it tries to use the git contributors to generate the manpage contributor list. The sources, of course, don't contain that information. Running the autogen script manually from a git clone of the repo works just fine. And the package.yml as it currently is in this diff works fine since all of that stuff is pre-generated in that source link. Any pointers as to what I can do here?

Try setting the source to:
git|https://github.com/thoughtbot/rcm.git : v1.3.3

This makes solbuild clone the entire repo tag with got instead of downloading the tar.gz file.

Try setting the source to:
git|https://github.com/thoughtbot/rcm.git : v1.3.3

This makes solbuild clone the entire repo tag with got instead of downloading the tar.gz file.

Well, that does get all the bits, but it still hangs at the same spot. Time to go find what the next difference is with the Github tag vs their official release package.