Page MenuHomeSolus

Trojita package submission
ClosedPublic

Authored by Clifspeare on May 8 2017, 6:09 PM.

Details

Summary

Patch submission for package of trojita mail client.

Uses new process

Diff Detail

Repository
R3402 trojita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Clifspeare created this revision.May 8 2017, 6:09 PM
Clifspeare retitled this revision from Initial commit to Trojita package submission.May 8 2017, 6:10 PM
Clifspeare edited the summary of this revision. (Show Details)
Clifspeare removed a reviewer: Triage Team.
Clifspeare added a project: Patch Submission.
Clifspeare added a reviewer: Triage Team.
JoshStrobl requested changes to this revision.May 10 2017, 1:53 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
6

This needs to be a download mirror URL like freefr.

16

Unnecessary. zlib-devel is part of system.devel

19

This should be below the Qt5Svg pkgconfig.

This revision now requires changes to proceed.May 10 2017, 1:53 PM
Clifspeare updated this revision to Diff 153.EditedMay 11 2017, 4:00 AM
Clifspeare edited edge metadata.

Removed explicit dependency on zlib-devel.
Packages reordered correctly.
I'm a sourceforge noob, trying to figure out how to set this to a mirror url.

Clifspeare updated this revision to Diff 154.May 11 2017, 4:23 AM

Got it. Source is now downloaded from mirror url.

JoshStrobl accepted this revision.May 11 2017, 8:17 AM

LGTM, nice work.

This revision is now accepted and ready to land.May 11 2017, 8:17 AM

Just something I noticed, package name should always be lowercased, not titled. I'll fix it post-merge.

This revision was automatically updated to reflect the committed changes.