Differential D64

Trojita package submission
ClosedPublic
Actions

Authored by Clifspeare on May 8 2017, 6:09 PM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T3454: Trojita Mail Client

Commits

R3402:8ec9ebe0b5f0: Trojita package submission

Summary

Patch submission for package of trojita mail client.

Uses new process

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Clifspeare created this revision.May 8 2017, 6:09 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMay 8 2017, 6:09 PM

Clifspeare retitled this revision from Initial commit to Trojita package submission.May 8 2017, 6:10 PM

Clifspeare edited the summary of this revision. (Show Details)

Clifspeare removed a reviewer: Triage Team.

Clifspeare added a project: Patch Submission.

Clifspeare added a reviewer: Triage Team.

Clifspeare added a task: T3454: Trojita Mail Client.

JoshStrobl requested changes to this revision.May 10 2017, 1:53 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
6	This needs to be a download mirror URL like freefr.
16	Unnecessary. zlib-devel is part of system.devel
19	This should be below the Qt5Svg pkgconfig.

This revision now requires changes to proceed.May 10 2017, 1:53 PM

Removed explicit dependency on zlib-devel.
Packages reordered correctly.
I'm a sourceforge noob, trying to figure out how to set this to a mirror url.

Got it. Source is now downloaded from mirror url.

LGTM, nice work.

This revision is now accepted and ready to land.May 11 2017, 8:17 AM

Just something I noticed, package name should always be lowercased, not titled. I'll fix it post-merge.

Closed by commit R3402:8ec9ebe0b5f0: Trojita package submission (authored by Clifspeare, committed by JoshStrobl). · Explain WhyMay 11 2017, 9:13 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
A	M		Makefile (1 line)
A	M		abi_symbols (73 lines)
A	M		abi_used_libs (14 lines)
A	M		package.yml (23 lines)
A	M		pspec_x86_64.xml (40 lines)

Diff 163

Makefile

Loading...

abi_symbols

Loading...

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...