Update python-sphinx to 2.2.1, drops Python 2.7 support
AbandonedPublic
Actions

Authored by • serebit on Jun 12 2019, 6:27 AM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Summary

Changelog available here

Test Plan

Install and build docs for the newest release of kitty

Diff Detail

Repository

R2698 python-sphinx

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• serebit created this revision.Jun 12 2019, 6:27 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptJun 12 2019, 6:27 AM

• serebit requested review of this revision.Jun 12 2019, 6:27 AM

Note that this requires extra extensions that were split off from the main repository. These will be added as separate differentials, akin to python-sphinxcontrib-websupport, if this revision is received positively.

Fixed incorrect release numbering

python-setuptools not required as its is a Python2 package

• serebit mentioned this in D6510: Initial inclusion of python-sphinxcontrib-applehelp.Jun 14 2019, 12:50 AM

• serebit added a parent revision: D6510: Initial inclusion of python-sphinxcontrib-applehelp.Jun 14 2019, 12:50 AM

• serebit mentioned this in D6511: Initial inclusion of python-sphinxcontrib-devhelp.Jun 14 2019, 12:51 AM

• serebit added a parent revision: D6511: Initial inclusion of python-sphinxcontrib-devhelp.Jun 14 2019, 12:52 AM

• serebit mentioned this in D6512: Initial inclusion of python-sphinxcontrib-htmlhelp.Jun 14 2019, 12:54 AM

• serebit added a parent revision: D6512: Initial inclusion of python-sphinxcontrib-htmlhelp.Jun 14 2019, 12:54 AM

• serebit mentioned this in D6513: Initial inclusion of python-sphinxcontrib-jsmath.Jun 14 2019, 12:55 AM

• serebit added a parent revision: D6513: Initial inclusion of python-sphinxcontrib-jsmath.Jun 14 2019, 12:55 AM

• serebit mentioned this in D6514: Initial inclusion of python-sphinxcontrib-qthelp.Jun 14 2019, 12:56 AM

• serebit added a parent revision: D6514: Initial inclusion of python-sphinxcontrib-qthelp.Jun 14 2019, 12:56 AM

• serebit mentioned this in D6515: Initial inclusion of python-sphinxcontrib-serializinghtml.Jun 14 2019, 12:57 AM

• serebit added a parent revision: D6515: Initial inclusion of python-sphinxcontrib-serializinghtml.Jun 14 2019, 12:57 AM

Removed unnecessary build and run dependencies. Tested with building kitty docs again to ensure stability.

Dropping python2 support would negatively affect spyder, which is python 2.

This revision now requires changes to proceed.Jun 28 2019, 2:47 PM

In D6496#104348, @JoshStrobl wrote:

Dropping python2 support would negatively affect spyder, which is python 2.

I think its hard time people migrate from spyder to spyder3.

In D6496#104409, @maverick1 wrote:

In D6496#104348, @JoshStrobl wrote:

Dropping python2 support would negatively affect spyder, which is python 2.

I think its hard time people migrate from spyder to spyder3.

That is not your call to make. And knowing spyder requires python 2 but still dropping support for it, without working with Core Team to determine if that is the best way forward, is incredibly irresponsible.

I just wanted to suggest it to people. I also didn't like it to drop python2 support if spyder needs it!

What would you suggest then, @JoshStrobl? I personally believe a slow migration towards a preference for Python 3 is a good way forward, but it's not my decision to make.