Page MenuHomeSolus

Update python-sphinx to 2.2.1, drops Python 2.7 support
Needs RevisionPublic

Authored by serebit on Jun 12 2019, 6:27 AM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

Changelog available here

Test Plan
  • Install and build docs for the newest release of kitty

Diff Detail

Repository
R2698 python-sphinx
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

serebit created this revision.Jun 12 2019, 6:27 AM
serebit requested review of this revision.Jun 12 2019, 6:27 AM

Note that this requires extra extensions that were split off from the main repository. These will be added as separate differentials, akin to python-sphinxcontrib-websupport, if this revision is received positively.

serebit updated this revision to Diff 15616.Jun 12 2019, 6:41 AM

Fixed incorrect release numbering

python-setuptools not required as its is a Python2 package

serebit updated this revision to Diff 15654.Jun 14 2019, 1:30 AM

Removed unnecessary build and run dependencies. Tested with building kitty docs again to ensure stability.

JoshStrobl requested changes to this revision.Jun 28 2019, 2:47 PM
JoshStrobl added a subscriber: JoshStrobl.

Dropping python2 support would negatively affect spyder, which is python 2.

This revision now requires changes to proceed.Jun 28 2019, 2:47 PM

Dropping python2 support would negatively affect spyder, which is python 2.

I think its hard time people migrate from spyder to spyder3.

Dropping python2 support would negatively affect spyder, which is python 2.

I think its hard time people migrate from spyder to spyder3.

That is not your call to make. And knowing spyder requires python 2 but still dropping support for it, without working with Core Team to determine if that is the best way forward, is incredibly irresponsible.

I just wanted to suggest it to people. I also didn't like it to drop python2 support if spyder needs it!

What would you suggest then, @JoshStrobl? I personally believe a slow migration towards a preference for Python 3 is a good way forward, but it's not my decision to make.

@serebit we havetto keep spyder2 until python reaches EOL for people who still maintain python2 code.