Page MenuHomeSolus

Create KDE integration package

Authored by livingsilver94 on Jun 10 2019, 7:26 PM.



Enable native Qt5 file dialogs on Solus Plasma by creating the libreoffice-common-kde-integration package.

I did not enable full Qt5 support because it doesn't play nicely with dark themes (e.g. Breeze Dark).

Test Plan

Browsed in menus and saved a file, setting a password via file dialog.
LibreOffice works correctly even if libreoffice-common-kde-integration is not installed; it correctly falls back to GTK3.

Diff Detail

R1835 libreoffice
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

livingsilver94 created this revision.Jun 10 2019, 7:26 PM
livingsilver94 requested review of this revision.Jun 10 2019, 7:26 PM

Oops, that's the version with full Qt5 support. Let me correct.

Fix derpiness

But now we'll be pulling in a bunch of KDE libs into the Budgie, GNOME, and MATE ISOs ๐Ÿค”

livingsilver94 added a comment.EditedJun 11 2019, 7:25 PM

Yeah I was waiting for a comment like that. That's a stupid behavior of LO as --help says that the KF5 bits are only loaded when available. A sentence like that makes me think that the dependencies are not forced.
I can reach LO devs for clarifications. Alternatively, we can manually instruct ypkg to skip those rundeps if possible.

Yea I would appreciate if we could split it up and have them be loaded dynamically, if LibreOffice in fact supports that. While I'm sure @Girtablulu might murder me, we could have a libreoffice-kde-integration package with those files and have that as part of the KDE ISO alongside LibreOffice.

livingsilver94 retitled this revision from Enable better KDE support to Add libreoffice-common-kde-integration package.Jun 13 2019, 11:16 AM
livingsilver94 edited the summary of this revision. (Show Details)
livingsilver94 edited the test plan for this revision. (Show Details)
livingsilver94 added a project: Plasma.
livingsilver94 retitled this revision from Add libreoffice-common-kde-integration package to Create KDE integration package.

Definitive edit (hopefully)

Add KDE metadata

JoshStrobl accepted this revision.Jul 2 2019, 5:49 PM

LGTM, thanks for all that work!

This revision is now accepted and ready to land.Jul 2 2019, 5:49 PM
This revision was automatically updated to reflect the committed changes.