Page MenuHomeSolus

Create KDE integration package
Needs ReviewPublic

Authored by livingsilver94 on Mon, Jun 10, 7:26 PM.

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

Enable native Qt5 file dialogs on Solus Plasma by creating the libreoffice-common-kde-integration package.

I did not enable full Qt5 support because it doesn't play nicely with dark themes (e.g. Breeze Dark).

Test Plan

Browsed in menus and saved a file, setting a password via file dialog.
LibreOffice works correctly even if libreoffice-common-kde-integration is not installed; it correctly falls back to GTK3.

Diff Detail

Repository
R1835 libreoffice
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
livingsilver94 created this revision.Mon, Jun 10, 7:26 PM
livingsilver94 requested review of this revision.Mon, Jun 10, 7:26 PM

Oops, that's the version with full Qt5 support. Let me correct.

Fix derpiness

But now we'll be pulling in a bunch of KDE libs into the Budgie, GNOME, and MATE ISOs ๐Ÿค”

livingsilver94 added a comment.EditedTue, Jun 11, 7:25 PM

Yeah I was waiting for a comment like that. That's a stupid behavior of LO as autogen.sh --help says that the KF5 bits are only loaded when available. A sentence like that makes me think that the dependencies are not forced.
I can reach LO devs for clarifications. Alternatively, we can manually instruct ypkg to skip those rundeps if possible.

Yea I would appreciate if we could split it up and have them be loaded dynamically, if LibreOffice in fact supports that. While I'm sure @Girtablulu might murder me, we could have a libreoffice-kde-integration package with those files and have that as part of the KDE ISO alongside LibreOffice.

livingsilver94 retitled this revision from Enable better KDE support to Add libreoffice-common-kde-integration package.Thu, Jun 13, 11:16 AM
livingsilver94 edited the summary of this revision. (Show Details)
livingsilver94 edited the test plan for this revision. (Show Details)
livingsilver94 added a project: Plasma.
livingsilver94 retitled this revision from Add libreoffice-common-kde-integration package to Create KDE integration package.

Definitive edit (hopefully)

Add KDE metadata