Page MenuHomeSolus

Update fzf to 0.18.0 and include the vim plugin

Authored by xulongwu4 on Jun 9 2019, 4:16 PM.



Update fzf to 0.18.0.
This patch also include the vim plugin, zsh auto-completion and shell key bindings.

  • Added placeholder expression for zero-based item index: {n} and {+n}
    • fzf --preview 'echo {n}: {}'
  • Added color option for the gutter: --color gutter:-1
  • Added --no-unicode option for drawing borders in non-Unicode, ASCII characters
  • FZF_PREVIEW_LINES and FZF_PREVIEW_COLUMNS are exported to preview process
    • fzf still overrides LINES and COLUMNS as before, but they may be reset by the default shell.
  • Bug fixes and improvements
Test Plan
  • Tested the vim plugin in vim using the FZF command
  • Tested the fzf command

Diff Detail

R864 fzf
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

xulongwu4 created this revision.Jun 9 2019, 4:16 PM
xulongwu4 requested review of this revision.Jun 9 2019, 4:16 PM
xulongwu4 edited the summary of this revision. (Show Details)Jun 9 2019, 4:38 PM
JoshStrobl requested changes to this revision.Jun 11 2019, 7:24 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.

To be clear, nothing wrong with your patch, but while we're updating this, let's go ahead and try to have the install calls be more aligned with other packages by consolidating the flags so instead of -D -m it's -Dm (example -Dm00755) and -d -m changes to -dm. Thanks for the patch!

This revision now requires changes to proceed.Jun 11 2019, 7:24 PM
xulongwu4 updated this revision to Diff 15634.Jun 13 2019, 11:40 AM

Fix the styles of the install calls.

xulongwu4 marked an inline comment as done.Jun 13 2019, 11:41 AM
xulongwu4 updated this revision to Diff 15675.Jun 16 2019, 2:26 PM

Rebase on master

JoshStrobl accepted this revision.Jun 21 2019, 1:42 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jun 21 2019, 1:42 PM
This revision was automatically updated to reflect the committed changes.