Page MenuHomeSolus

Initial commit of qogir-theme. Fixes T7523.
Needs ReviewPublic

Authored by algent on Wed, Jun 5, 3:27 PM.

Details

Reviewers
Justin
Girtablulu
Group Reviewers
Triage Team
Maniphest Tasks
T7523: Qogir GTK Theme
Summary

Initial commit of qogir-theme. Fixes T7523.

Test Plan

Tested on Budgie Desktop.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
algent created this revision.Wed, Jun 5, 3:27 PM
algent requested review of this revision.Wed, Jun 5, 3:27 PM
Justin requested changes to this revision.Sat, Jun 8, 5:57 AM
Justin added a subscriber: Justin.
Justin added inline comments.
package.yml
13

Is it needed to build or just run?

14

Should be

- pkgconfig(gdk-pixbuf-2.0)
15

All of the below should be in the install step, not build.

This revision now requires changes to proceed.Sat, Jun 8, 5:57 AM
algent updated this revision to Diff 15576.Sat, Jun 8, 8:58 AM

From Revision. Fixed bulddeps and build

Girtablulu requested changes to this revision.Sat, Jun 8, 5:48 PM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
7

Needs to be SPDX conform

20

you could slim this section down by using

rm -rf $installdir/usr/share/themes/*/{cinnamon,AUTHORS,COPYING}

This revision now requires changes to proceed.Sat, Jun 8, 5:48 PM
algent updated this revision to Diff 15580.Sat, Jun 8, 8:49 PM
algent marked 2 inline comments as done.

Revision fixes. License with SPDX identifier and install process

You should update the description to something like Initial commit of qogir-theme. Fixes T7523.

That way the task will be closed automatically once your patch is accepted. The bot looks certain wording.

algent marked 2 inline comments as done.Wed, Jun 12, 9:59 PM

@davidjharder Thank you! I will keep in mind that.

package.yml
7

I found that this is GPL-3.0-or-later. If no other changes are needed I can change this again.

13

From the author it is stated that they are "GTK2 engines requirment".

  • GTK2 engine Murrine 0.98.1.1 or later.
  • GTK2 pixbuf engine or the gtk(2)-engines package.
14

Placed it on rundeps, and gave me an error during instalation so i replaced it with "gdk-pixbuf"

algent updated this revision to Diff 15633.Wed, Jun 12, 10:12 PM
algent marked an inline comment as done.

Updated Description and License

algent retitled this revision from Initial commit of qogir-theme for T7523 to Initial commit of qogir-theme. Fixes T7523..Wed, Jun 12, 10:17 PM
algent edited the summary of this revision. (Show Details)
algent updated this revision to Diff 15685.Mon, Jun 17, 5:26 PM
algent marked 4 inline comments as done.

Fixed rundeps in alphabetical order.