Page MenuHomeSolus

Update dolphin-emu to June/July 2019 progress report
Needs ReviewPublic

Authored by Jacalz on Jun 3 2019, 9:13 AM.

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

Summarized Changelog:

  • Implement "Drawsome" tablet.
  • Implement "Taiko no Tatsujin" Drumset.
  • Allow interatcing with render window while configuring controllers.
  • Implement passive stereoscopic 3D.
  • IOS HLE fixes and passthrough upgrades.
  • VideoCommon: Constrain the array_base registers.
  • A lot of major and minor game fixes overall.

The full May progress report can be found here and the June/July report can be found here.

Test Plan
  • Testing with Wii Sports, Super Mario Galaxy, New Super Mario Bros and Mario Cart Wii.

Diff Detail

Repository
R654 dolphin-emu
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Jacalz created this revision.Jun 3 2019, 9:13 AM
Jacalz requested review of this revision.Jun 3 2019, 9:13 AM

I want to take advantage of this differential to ask Core Team if we have any policy about optimization flags.

Jacek added a subscriber: Jacek.Jun 10 2019, 5:54 AM
Jacalz updated this revision to Diff 16244.EditedJul 18 2019, 6:52 PM
  • Update against new LLVM-8 updates in unstable
Jacalz updated this revision to Diff 16261.Jul 19 2019, 8:43 AM
  • Move optimizations to make sure that they always are done
Jacalz retitled this revision from Update dolphin-emu to May 2019 progress report and enable optimizations to Update dolphin-emu to May 2019 progress report (with libusb hotfix) and enable optimizations.Jul 19 2019, 8:45 AM
Jacalz edited the summary of this revision. (Show Details)
Jacalz edited the test plan for this revision. (Show Details)
Jacalz updated this revision to Diff 16546.Aug 7 2019, 1:40 PM
  • Update to the June/July progress report
Jacalz retitled this revision from Update dolphin-emu to May 2019 progress report (with libusb hotfix) and enable optimizations to Update dolphin-emu to June/July 2019 progress report and enable optimizations.Aug 7 2019, 6:23 PM
Jacalz edited the summary of this revision. (Show Details)
Jacalz edited the summary of this revision. (Show Details)
Jacalz edited the test plan for this revision. (Show Details)

Built and tested with several games, works perfectly for me.

Built and tested with several games, works perfectly for me.

Wonderful that you are seeing the same results and thanks for the extra testing 👍

Jacalz updated this revision to Diff 16716.Aug 17 2019, 8:44 AM
  • Correctly rebase on top of LLVM-8 update
Jacalz edited the summary of this revision. (Show Details)Aug 17 2019, 8:46 AM
Jacalz updated this revision to Diff 16971.Aug 31 2019, 7:15 PM
  • Remove optimizations because size increase is not worth it
Jacalz retitled this revision from Update dolphin-emu to June/July 2019 progress report and enable optimizations to Update dolphin-emu to June/July 2019 progress report.Aug 31 2019, 7:15 PM
Jacalz edited the test plan for this revision. (Show Details)
Jacalz edited the summary of this revision. (Show Details)

In general, LTO gives a reduction is size, although often negligible. Why did you remove it as well?

Jacalz added a comment.Sep 1 2019, 5:02 PM

In general, LTO gives a reduction is size, although often negligible. Why did you remove it as well?

I am honestly tired of compiling, testing and repeating it over and over again for this package. I am putting it back to how it was before I started optimizing it. Might (almost certainly) come back to this in the next update revision and see about using LTO...