Page MenuHomeSolus

Updated Love to 11.2 (Mysterious Mysteries)
Needs ReviewPublic

Authored by apolius on Jun 2 2019, 10:25 AM.

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

Updated Love to 11.0 (Mysterious Mysteries),
duckmarines and sienna are updated aswell.

Test Plan

Play some games :)

Diff Detail

Repository
R1979 love
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

apolius created this revision.Jun 2 2019, 10:25 AM
apolius requested review of this revision.Jun 2 2019, 10:25 AM

Soooo. We can't update Love right now because it breaks Sienna and Mr Rescue. I don't want to deprecate them from the repo if we can avoid it. See: https://dev.getsol.us/D5018

Last time this came up this got a little heated for whatever reason, so if we can calmly and collectively come up with a solution, I'd appreciate it.

And for your future reference, any time a library gets updated, all applications that rely on it need to be tested.

I already found out about this and i am working on updating the effected games to the newer version

As in porting them to love 11?

Would it be possible to have the games that don't work in the latest version hang onto an older version? In fact, we could actually have the game shipped with the appropriate Love binary (since the games actually don't have a binary included with them right now. Either way is fine with me, just wondering how we can ensure things keep working with minimal effort going forward, since Love will always be a moving target.

The reverse dependencies have been updated, please review and let me know if I did something wrong !