Page MenuHomeSolus

Initial commit of Cinelerra-GG for T7595
ClosedPublic

Authored by Jacek on May 27 2019, 2:44 PM.

Details

Summary

Initial commit of Cinelerra-GG for T7595

Test Plan

It is a video editor, so create a test video, add a few video effects and render

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Jacek created this revision.May 27 2019, 2:44 PM
Jacek requested review of this revision.May 27 2019, 2:44 PM
livingsilver94 added inline comments.
package.yml
9

it's its.

Jacek updated this revision to Diff 15503.May 27 2019, 3:12 PM

Corrected worst possible mistake

livingsilver94 added inline comments.May 27 2019, 3:14 PM
package.yml
7

Since you like sarcasm, I gotta tell you that here you should write GPL-2.0-or-later :P

Jacek updated this revision to Diff 15504.May 27 2019, 3:27 PM

Initial commit of Cinelerra-GG

Jacek updated this revision to Diff 15506.May 27 2019, 7:17 PM

Removed redundand dependencies

Jacek updated this revision to Diff 15507.May 27 2019, 7:50 PM

5th revision of initial commit of Cinelerra-GG

Jacek updated this revision to Diff 15514.May 28 2019, 7:31 PM

6th iteration of Initial commit of Cinelerra-GG

livingsilver94 added inline comments.May 28 2019, 7:39 PM
package.yml
66

Don't say "this update", Cinelerra will be updated in future. Use "2019.04.30" so that it's an absolute value.

77

You can then use make install DESTDIR="$installdir" --with-jobs %JOBS%

Jacek added inline comments.May 28 2019, 7:48 PM
package.yml
77

Cinelerra automaticially creates jobs based on number of cores, so that prefix according to their readme is not necessary

Jacek updated this revision to Diff 15515.May 28 2019, 7:59 PM

7th iteration of Initial commit of Cinelerra-GG

livingsilver94 added inline comments.May 28 2019, 8:48 PM
package.yml
77

Well OK, I guess that's a matter of preference. Using %JOBS% would be self-documenting, but I won't insist on that.

Jacek added inline comments.May 28 2019, 9:08 PM
package.yml
77

In Cinelerra it bizarrely is passed with configure not make install, so it has to be configure --with-jobs %JOBS%. And I have configure included in %autogen, so it'd have to be messy

JoshStrobl requested changes to this revision.May 31 2019, 12:30 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
14–55

You need to cleanup your builddeps, you have a bunch of redundant pkgconfigs that aren't needed because of dependencies or depending, their reverse dependencies already specified (example, fribidi is a dep of pango which is a dep of gtk2)

14–65

Need to fix indentation, no empty lines.

66

Comment unnecessary.

69

Remove comment.

This revision now requires changes to proceed.May 31 2019, 12:30 PM
Jacek updated this revision to Diff 15534.Jun 2 2019, 4:32 PM

Updated package to newest version, removed redundand dependencies, adjusted styling to Josh's standards

Jacek updated this revision to Diff 15546.Jun 3 2019, 3:51 PM

Fixed a mistake I made while deleting reverse dependencies, sorry, I swear this is the last one

Jacek updated this revision to Diff 15551.Jun 4 2019, 1:26 PM

Removed 3 additional dependencies that other distros need to build it but solbuild doesn't

Jacek retitled this revision from Initial commit of Cinelerra-GG to Initial commit of Cinelerra-GG for T7595.Jun 8 2019, 8:28 PM
Jacek edited the summary of this revision. (Show Details)
Jacek updated this revision to Diff 16158.Jul 11 2019, 7:10 PM

Updated package, because I've waited for so long for review, another (monthly) version has been released. Please, somebody just review it!

JoshStrobl requested changes to this revision.Jul 15 2019, 2:31 PM

LGTM, nice work on the patch and going through the builddeps to check for anything that was unnecessary, much appreciated (at least, I didn't catch any when I went through the list). That's a whole lot of pkgconfigs.

While we're making changes to this, let's go ahead and add a MAINTAINERS.md file to the cinelerra-gg repo (as opposed to inside the package). Feel free to copy / paste the content below!

This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository.

- Jacek Jagosz
  - IRC: JacekJagosz
  - Email: jacek.jagosz@outlook.com
pspec_x86_64.xml
1400

Only issue with the patch is that this just needs a rebuild to ensure the release is 1.

This revision now requires changes to proceed.Jul 15 2019, 2:31 PM
Jacek updated this revision to Diff 16205.Jul 15 2019, 3:52 PM

Added MAINTAINERS.md and rebuilt so it is release 1 in pspec_x86_64.xml.
Thanks Josh!

Jacek updated this revision to Diff 16206.Jul 15 2019, 4:03 PM

Removed indentation on line 3 in MAINTAINERS.md

JoshStrobl accepted this revision.Jul 15 2019, 4:04 PM
This revision is now accepted and ready to land.Jul 15 2019, 4:04 PM
This revision was automatically updated to reflect the committed changes.