Page MenuHomeSolus

Initial commit of Cinelerra-GG for T7595

Authored by Jacek on May 27 2019, 2:44 PM.
Referenced Files
F10806327: D6439.id16158.diff
Tue, May 30, 12:37 AM
F10806207: D6439.id15534.diff
Tue, May 30, 12:02 AM
F10806141: D6439.id15546.diff
Mon, May 29, 11:45 PM
F10805990: D6439.id15515.diff
Mon, May 29, 11:02 PM
F10805632: D6439.id16205.diff
Mon, May 29, 9:21 PM
F10805558: D6439.id15503.diff
Mon, May 29, 8:58 PM
F10804391: D6439.diff
Mon, May 29, 3:56 PM
F10772439: D6439.id15504.diff
Sun, May 21, 12:46 PM
"Party Time" token, awarded by abdulocracy."Dat Boi" token, awarded by livingsilver94.



Initial commit of Cinelerra-GG for T7595

Test Plan

It is a video editor, so create a test video, add a few video effects and render

Diff Detail

No Lint Coverage
No Test Coverage

Event Timeline

Jacek requested review of this revision.May 27 2019, 2:44 PM
livingsilver94 added inline comments.

it's its.

Corrected worst possible mistake


Since you like sarcasm, I gotta tell you that here you should write GPL-2.0-or-later :P

Initial commit of Cinelerra-GG

Removed redundand dependencies

5th revision of initial commit of Cinelerra-GG

6th iteration of Initial commit of Cinelerra-GG


Don't say "this update", Cinelerra will be updated in future. Use "2019.04.30" so that it's an absolute value.


You can then use make install DESTDIR="$installdir" --with-jobs %JOBS%


Cinelerra automaticially creates jobs based on number of cores, so that prefix according to their readme is not necessary

7th iteration of Initial commit of Cinelerra-GG


Well OK, I guess that's a matter of preference. Using %JOBS% would be self-documenting, but I won't insist on that.


In Cinelerra it bizarrely is passed with configure not make install, so it has to be configure --with-jobs %JOBS%. And I have configure included in %autogen, so it'd have to be messy

JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.

You need to cleanup your builddeps, you have a bunch of redundant pkgconfigs that aren't needed because of dependencies or depending, their reverse dependencies already specified (example, fribidi is a dep of pango which is a dep of gtk2)


Need to fix indentation, no empty lines.


Comment unnecessary.


Remove comment.

This revision now requires changes to proceed.May 31 2019, 12:30 PM

Updated package to newest version, removed redundand dependencies, adjusted styling to Josh's standards

Fixed a mistake I made while deleting reverse dependencies, sorry, I swear this is the last one

Removed 3 additional dependencies that other distros need to build it but solbuild doesn't

Jacek retitled this revision from Initial commit of Cinelerra-GG to Initial commit of Cinelerra-GG for T7595.Jun 8 2019, 8:28 PM
Jacek edited the summary of this revision. (Show Details)

Updated package, because I've waited for so long for review, another (monthly) version has been released. Please, somebody just review it!

LGTM, nice work on the patch and going through the builddeps to check for anything that was unnecessary, much appreciated (at least, I didn't catch any when I went through the list). That's a whole lot of pkgconfigs.

While we're making changes to this, let's go ahead and add a file to the cinelerra-gg repo (as opposed to inside the package). Feel free to copy / paste the content below!

This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository.

- Jacek Jagosz
  - IRC: JacekJagosz
  - Email:

Only issue with the patch is that this just needs a rebuild to ensure the release is 1.

This revision now requires changes to proceed.Jul 15 2019, 2:31 PM

Added and rebuilt so it is release 1 in pspec_x86_64.xml.
Thanks Josh!

Removed indentation on line 3 in

This revision is now accepted and ready to land.Jul 15 2019, 4:04 PM
This revision was automatically updated to reflect the committed changes.