Initial commit of Cinelerra-GG for T7595
Details
Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Commits
- R4773:e3a1253e1c96: Initial commit of Cinelerra-GG for T7595
It is a video editor, so create a test video, add a few video effects and render
Diff Detail
Diff Detail
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| package.yml | ||
|---|---|---|
| 9 | it's its. | |
| package.yml | ||
|---|---|---|
| 7 | Since you like sarcasm, I gotta tell you that here you should write GPL-2.0-or-later :P | |
| package.yml | ||
|---|---|---|
| 77 | Cinelerra automaticially creates jobs based on number of cores, so that prefix according to their readme is not necessary | |
| package.yml | ||
|---|---|---|
| 77 | Well OK, I guess that's a matter of preference. Using %JOBS% would be self-documenting, but I won't insist on that. | |
| package.yml | ||
|---|---|---|
| 77 | In Cinelerra it bizarrely is passed with configure not make install, so it has to be configure --with-jobs %JOBS%. And I have configure included in %autogen, so it'd have to be messy | |
| package.yml | ||
|---|---|---|
| 14–55 | You need to cleanup your builddeps, you have a bunch of redundant pkgconfigs that aren't needed because of dependencies or depending, their reverse dependencies already specified (example, fribidi is a dep of pango which is a dep of gtk2) | |
| 14–65 | Need to fix indentation, no empty lines. | |
| 66 | Comment unnecessary. | |
| 69 | Remove comment. | |
Comment Actions
Updated package to newest version, removed redundand dependencies, adjusted styling to Josh's standards
Comment Actions
Fixed a mistake I made while deleting reverse dependencies, sorry, I swear this is the last one
Comment Actions
Removed 3 additional dependencies that other distros need to build it but solbuild doesn't
Comment Actions
Updated package, because I've waited for so long for review, another (monthly) version has been released. Please, somebody just review it!
Comment Actions
LGTM, nice work on the patch and going through the builddeps to check for anything that was unnecessary, much appreciated (at least, I didn't catch any when I went through the list). That's a whole lot of pkgconfigs.
While we're making changes to this, let's go ahead and add a MAINTAINERS.md file to the cinelerra-gg repo (as opposed to inside the package). Feel free to copy / paste the content below!
This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository. - Jacek Jagosz - IRC: JacekJagosz - Email: jacek.jagosz@outlook.com
| pspec_x86_64.xml | ||
|---|---|---|
| 1400 | Only issue with the patch is that this just needs a rebuild to ensure the release is 1. | |
Comment Actions
Added MAINTAINERS.md and rebuilt so it is release 1 in pspec_x86_64.xml.
Thanks Josh!