Page MenuHomeSolus

Initial commit of Cinelerra-GG for T7595
Needs ReviewPublic

Authored by Jacek on Mon, May 27, 2:44 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

Initial commit of Cinelerra-GG for T7595

Test Plan

It is a video editor, so create a test video, add a few video effects and render

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Jacek created this revision.Mon, May 27, 2:44 PM
Jacek requested review of this revision.Mon, May 27, 2:44 PM
livingsilver94 added inline comments.
package.yml
9

it's its.

Jacek updated this revision to Diff 15503.Mon, May 27, 3:12 PM

Corrected worst possible mistake

livingsilver94 added inline comments.Mon, May 27, 3:14 PM
package.yml
7

Since you like sarcasm, I gotta tell you that here you should write GPL-2.0-or-later :P

Jacek updated this revision to Diff 15504.Mon, May 27, 3:27 PM

Initial commit of Cinelerra-GG

Jacek updated this revision to Diff 15506.Mon, May 27, 7:17 PM

Removed redundand dependencies

Jacek updated this revision to Diff 15507.Mon, May 27, 7:50 PM

5th revision of initial commit of Cinelerra-GG

Jacek updated this revision to Diff 15514.Tue, May 28, 7:31 PM

6th iteration of Initial commit of Cinelerra-GG

livingsilver94 added inline comments.Tue, May 28, 7:39 PM
package.yml
66

Don't say "this update", Cinelerra will be updated in future. Use "2019.04.30" so that it's an absolute value.

77

You can then use make install DESTDIR="$installdir" --with-jobs %JOBS%

Jacek added inline comments.Tue, May 28, 7:48 PM
package.yml
77

Cinelerra automaticially creates jobs based on number of cores, so that prefix according to their readme is not necessary

Jacek updated this revision to Diff 15515.Tue, May 28, 7:59 PM

7th iteration of Initial commit of Cinelerra-GG

livingsilver94 added inline comments.Tue, May 28, 8:48 PM
package.yml
77

Well OK, I guess that's a matter of preference. Using %JOBS% would be self-documenting, but I won't insist on that.

Jacek added inline comments.Tue, May 28, 9:08 PM
package.yml
77

In Cinelerra it bizarrely is passed with configure not make install, so it has to be configure --with-jobs %JOBS%. And I have configure included in %autogen, so it'd have to be messy

JoshStrobl requested changes to this revision.Fri, May 31, 12:30 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
14–55

You need to cleanup your builddeps, you have a bunch of redundant pkgconfigs that aren't needed because of dependencies or depending, their reverse dependencies already specified (example, fribidi is a dep of pango which is a dep of gtk2)

14–65

Need to fix indentation, no empty lines.

66

Comment unnecessary.

69

Remove comment.

This revision now requires changes to proceed.Fri, May 31, 12:30 PM
Jacek updated this revision to Diff 15534.Sun, Jun 2, 4:32 PM

Updated package to newest version, removed redundand dependencies, adjusted styling to Josh's standards

Jacek updated this revision to Diff 15546.Mon, Jun 3, 3:51 PM

Fixed a mistake I made while deleting reverse dependencies, sorry, I swear this is the last one

Jacek updated this revision to Diff 15551.Tue, Jun 4, 1:26 PM

Removed 3 additional dependencies that other distros need to build it but solbuild doesn't

Jacek retitled this revision from Initial commit of Cinelerra-GG to Initial commit of Cinelerra-GG for T7595.Sat, Jun 8, 8:28 PM
Jacek edited the summary of this revision. (Show Details)