Page MenuHomeSolus

Update rust to 1.35
AbandonedPublic

Authored by Girtablulu on Sat, May 25, 6:42 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

Update rust to 1.35

Chnagelog available here

Test Plan

Build cbindgen, firefox and thunderbird against this version

Diff Detail

Repository
R2839 rust
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Girtablulu created this revision.Sat, May 25, 6:42 PM
Girtablulu requested review of this revision.Sat, May 25, 6:42 PM

Is cargo still dynamically linked against libgit2 and libssh2?

don't see anything regarding this inside the changelog

Can you try with ldd?

JoshStrobl requested changes to this revision.Mon, May 27, 12:46 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
pspec_x86_64.xml
21–1574

None of this should exist or needs to be moved / fixed.

This revision now requires changes to proceed.Mon, May 27, 12:46 PM
Girtablulu abandoned this revision.Mon, Jun 3, 2:16 PM

going to abandoned this because I do not have time to work on it this month, so if anyone else has some freetime and wanna pick this up be my guest

looks at @livingsilver94 :)

livingsilver94 added a comment.EditedMon, Jun 3, 2:19 PM

Yeah yeah, I'll do it :P
@JoshStrobl what's wrong with LLVM? Rust requires its patched version of LLVM to work. To be frank, we could force it to use system's LLVM, but without Rust's specific patches that could turn into a sea of woes.
I can reach Rust devs to ask if this is still valid though, my information is old.

@livingsilver94 thx man!!

regarding your question, look at the path I totally missed that one

livingsilver94 added a comment.EditedMon, Jun 3, 2:56 PM

Oops right, I read them right-to-left so I missed the path.

Oops right, I read them right-to-left so I missed the path.

Just so you're aware, English is read left to right.

#JoshFacts

livingsilver94 added inline comments.Thu, Jun 6, 11:30 AM
pspec_x86_64.xml
21–1574

@JoshStrobl do you know why that's happening? I think it's ypkg automatically adding them but they're not in $installdir...