Page MenuHomeSolus

Update python-decorator to 4.3.2
ClosedPublic

Authored by maverick1 on May 21 2019, 6:03 PM.

Details

Summary

Update python-decorator to 4.3.2

Changes

  • Fixed a regression with decorator factories breaking the case with no arguments by going back to the syntax used in version 4.2.
  • Now the decorator module can decorate generator functions by preserving their being generator functions.
  • Extended the decorator family facility to work with positional arguments and updated the documentation. Removed decorator.getargspec and provided decorator.getfullargspec instead.
Test Plan

Ran some example codes from the documentation site and tested with reverse dependencies like ipython, thefuck and networkx

Diff Detail

Repository
R3482 python-decorator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

maverick1 created this revision.May 21 2019, 6:03 PM
maverick1 requested review of this revision.May 21 2019, 6:03 PM
JoshStrobl requested changes to this revision.May 27 2019, 10:52 AM
JoshStrobl added a subscriber: JoshStrobl.

Ran some example codes from the documentation site

And what about it's revdeps?

This revision now requires changes to proceed.May 27 2019, 10:52 AM

ipython, thefuck and networkx working.

maverick1 requested review of this revision.Jun 19 2019, 11:24 AM
maverick1 edited the test plan for this revision. (Show Details)Jun 19 2019, 11:35 AM
JoshStrobl accepted this revision.Jun 28 2019, 2:24 PM

In which case LGTM, thanks!

This revision is now accepted and ready to land.Jun 28 2019, 2:24 PM
This revision was automatically updated to reflect the committed changes.