Page MenuHomeSolus
Differential D6384

Initial inclusion of lua-filesystem
AbandonedPublic
Actions

Authored by dotEls on May 21 2019, 3:38 PM.
Tags
None
Referenced Files
F11004445: D6384.diff
Tue, Aug 1, 1:32 AM
F10993166: D6384.diff
Tue, Jul 25, 3:58 PM
F10970834: D6384.id15397.diff
Fri, Jul 21, 4:27 AM
F10864110: D6384.diff
Jun 17 2023, 6:29 AM
F10852723: D6384.id15399.diff
Jun 13 2023, 3:59 AM
F10848692: D6384.id15397.diff
Jun 11 2023, 4:17 PM
F10848133: D6384.id15395.diff
Jun 11 2023, 1:35 PM
F10845893: D6384.id15396.diff
Jun 11 2023, 2:51 AM
View All 18 Files
Subscribers
JoshStrobl
livingsilver94

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T5351: LuaFileSystem
Summary

Initial commit of lua-filesystem. Fixes T5351

Test Plan

Ran the LuaFileSystem test

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

dotEls created this revision.May 21 2019, 3:38 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptMay 21 2019, 3:38 PM
dotEls requested review of this revision.May 21 2019, 3:38 PM
dotEls updated this revision to Diff 15396.May 21 2019, 3:46 PM
dotEls edited the summary of this revision. (Show Details)

Initial commit of lua-filesystem

dotEls updated this revision to Diff 15397.May 21 2019, 3:54 PM
dotEls edited the summary of this revision. (Show Details)
dotEls added a task: T5351: LuaFileSystem.

Initial commit of lua-filesystem

dotEls mentioned this in T5351: LuaFileSystem.May 21 2019, 3:58 PM
livingsilver94 added a subscriber: livingsilver94.May 21 2019, 5:07 PM
livingsilver94 added inline comments.
package.yml
9

This is a bit too long for a summary. Try to shorten the sentence.

18

We usually put build phases in this order: build -> install -> check. Just move install before check.

dotEls updated this revision to Diff 15399.May 21 2019, 5:34 PM

Build order changed
Summary shortened.

JoshStrobl requested changes to this revision.May 27 2019, 10:51 AM
JoshStrobl added a subscriber: JoshStrobl.

Ran the LuaFileSystem test

While great, this needs to be improved with some test plan code (doesn't need to be anything fancy) indicating it works. Otherwise LGTM.

This revision now requires changes to proceed.May 27 2019, 10:51 AM
JoshStrobl abandoned this revision.Jul 5 2019, 3:06 PM

Revision Contents
Changeset List

PathSize
1 line
1 line
18 lines
34 lines

Diff 15399

View Options

Makefile

Loading...
View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.