Page MenuHomeSolus

Initial inclusion of lua-filesystem
AbandonedPublic

Authored by dotEls on May 21 2019, 3:38 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T5351: LuaFileSystem
Summary

Initial commit of lua-filesystem. Fixes T5351

Test Plan

Ran the LuaFileSystem test

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

dotEls created this revision.May 21 2019, 3:38 PM
dotEls requested review of this revision.May 21 2019, 3:38 PM
dotEls updated this revision to Diff 15396.May 21 2019, 3:46 PM
dotEls edited the summary of this revision. (Show Details)

Initial commit of lua-filesystem

dotEls updated this revision to Diff 15397.May 21 2019, 3:54 PM
dotEls edited the summary of this revision. (Show Details)

Initial commit of lua-filesystem

livingsilver94 added inline comments.
package.yml
9

This is a bit too long for a summary. Try to shorten the sentence.

18

We usually put build phases in this order: build -> install -> check. Just move install before check.

dotEls updated this revision to Diff 15399.May 21 2019, 5:34 PM

Build order changed
Summary shortened.

JoshStrobl requested changes to this revision.May 27 2019, 10:51 AM
JoshStrobl added a subscriber: JoshStrobl.

Ran the LuaFileSystem test

While great, this needs to be improved with some test plan code (doesn't need to be anything fancy) indicating it works. Otherwise LGTM.

This revision now requires changes to proceed.May 27 2019, 10:51 AM
JoshStrobl abandoned this revision.Jul 5 2019, 3:06 PM