initial repo setup for nbd.
ClosedPublic
Actions

package.yml
7	License should be GPL-2.0-or-later
14	You can probably remove glib2 from the builddeps as it’s part of system.base and will get installed automatically.

package.yml
3	Not super important, but common knowledge is to put version number in between two single quotes where there are only two numbers. So if the version was 3.19.0 you’d write that but for 3.19 you’d do ‘3.19’. :)

Girtablulu added inline comments.

package.yml
22	This could be thrown into /usr/share/defaults to keep the package stateless

Girtablulu requested changes to this revision.May 19 2019, 1:26 PM

This revision now requires changes to proceed.May 19 2019, 1:26 PM

kyrios123 added inline comments.

package.yml
22	Please also use 5 digits for the permissions 00644

fix version number.

move sample config to /usr/share/defaults; use 5-digit permission

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2019, 10:49 PM

Closed by commit R4745:9a8b8ddcb175: initial repo setup for nbd. (authored by hash <hashhsah@gmail.com>, committed by DataDrake). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15247	4b825dc		May 19 2019, 10:39 AM	★	★
Diff 2	15252	4b825dc	fix version number.	May 19 2019, 2:28 PM	★	★
Diff 3	15257	4b825dc	move sample config to /usr/share/defaults; use 5-digit permission	May 19 2019, 3:43 PM	★	★
Diff 4	15344	6b927b8	R4745:9a8b8ddcb175829ccf66e8a540b85e5868879d08	May 20 2019, 10:49 PM	★	★