Page MenuHomeSolus

initial repo setup for nbd.
ClosedPublic

Authored by hashhsah on May 19 2019, 10:39 AM.

Details

Summary

Resolves T7696

nbd example config files are placed in /etc/nbd-server,
systemd service unit files installed but not enabled.

Test Plan

make an image file /export/nbd/experiment,
start service, connect with nbd-client and mount it.

Diff Detail

Repository
R4745 nbd
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hashhsah created this revision.May 19 2019, 10:39 AM
hashhsah requested review of this revision.May 19 2019, 10:39 AM
Jacalz added a subscriber: Jacalz.May 19 2019, 12:51 PM
Jacalz added inline comments.
package.yml
7

License should be GPL-2.0-or-later

14

You can probably remove glib2 from the builddeps as it’s part of system.base and will get installed automatically.

Jacalz added inline comments.May 19 2019, 12:55 PM
package.yml
3

Not super important, but common knowledge is to put version number in between two single quotes where there are only two numbers. So if the version was 3.19.0 you’d write that but for 3.19 you’d do ‘3.19’. :)

Girtablulu added inline comments.
package.yml
22

This could be thrown into /usr/share/defaults to keep the package stateless

Girtablulu requested changes to this revision.May 19 2019, 1:26 PM
This revision now requires changes to proceed.May 19 2019, 1:26 PM
kyrios123 added inline comments.
package.yml
22

Please also use 5 digits for the permissions 00644

hashhsah updated this revision to Diff 15252.May 19 2019, 2:29 PM

fix version number.

hashhsah updated this revision to Diff 15257.May 19 2019, 3:43 PM

move sample config to /usr/share/defaults; use 5-digit permission

DataDrake accepted this revision.May 20 2019, 10:47 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2019, 10:49 PM
Closed by commit R4745:9a8b8ddcb175: initial repo setup for nbd. (authored by hash <hashhsah@gmail.com>, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.