Page MenuHomeSolus

Update flask to 1.0.3 and drop python2 support
ClosedPublic

Authored by maverick1 on May 18 2019, 1:47 PM.

Details

Summary

Update flask to 1.0.3 and drop python2 support

Changes

  • Allow custom CLIs using FlaskGroup to set the debug flag without it always being overwritten based on environment variables.
  • flask --version outputs Werkzeug's version and simplifies the Python version.
  • A catch-all error handler registered for HTTPException will not handle RoutingException, which is used internally during routing.
  • Passing the json argument to app.test_client does not push/pop an extra app context.
  • :func:send_file encodes filenames as ASCII instead of Latin-1 (ISO-8859-1). This fixes compatibility with Gunicorn, which is stricter about header encodings than PEP 3333.
Test Plan

Ran flask server with simple flask routing code.

Diff Detail

Repository
R765 flask
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

maverick1 created this revision.May 18 2019, 1:47 PM
maverick1 requested review of this revision.May 18 2019, 1:47 PM
DataDrake accepted this revision.May 20 2019, 10:40 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.May 20 2019, 10:40 PM
This revision was automatically updated to reflect the committed changes.