Page MenuHomeSolus

Update cmake to 3.14.4
ClosedPublic

Authored by Girtablulu on May 15 2019, 2:26 PM.

Details

Summary

Update cmake to 3.14.4

Changelog:

  • 3.14.4
    • In CMake 3.14.0 through 3.14.3, calling target_link_libraries() to add PRIVATE dependencies to a static library created in another directory (under policy CMP0079 NEW behavior) would incorrectly propagate usage requirements of those dependencies to dependents that link the static library.
  • 3.14.3
    • The CMAKE_VS_PLATFORM_NAME_DEFAULT variable was added to help toolchain files work with the Visual Studio 16 2019 generator where the default platform now depends on the host platform.
Test Plan

Build python-qtpy successfully with it

Diff Detail

Repository
R535 cmake
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Girtablulu created this revision.May 15 2019, 2:26 PM
Girtablulu requested review of this revision.May 15 2019, 2:26 PM
DataDrake accepted this revision.May 16 2019, 9:35 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.May 16 2019, 9:35 PM
This revision was automatically updated to reflect the committed changes.