Page MenuHomeSolus

Initial Commit of steamos-modeswitch-inhibitor for T4194
AbandonedPublic

Authored by eyecreate on May 10 2019, 8:27 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Summary

Includes shared lib used by steamos for inhibiting modeswitching when in Big Picture mode. See T4194.

Test Plan

Not sure how to test by itself, but results from running with steamos compositor seems to show working.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

eyecreate created this revision.May 10 2019, 8:27 PM
eyecreate requested review of this revision.May 10 2019, 8:27 PM
eyecreate edited the summary of this revision. (Show Details)Jul 17 2019, 9:03 PM
DataDrake requested changes to this revision.Apr 13 2020, 2:05 AM
DataDrake added a subscriber: DataDrake.

At this point this is old enough that I need to see an updated patch and that the maintainer is still interested.

package.yml
12

Make sure none of these are already dependencies of other ones in the list.

14

Should be pkgconfig(gl)

28

Is this empty or are files missing?

This revision now requires changes to proceed.Apr 13 2020, 2:05 AM
eyecreate added inline comments.Apr 14 2020, 2:13 AM
package.yml
12

Is there a way I can check this without trying to find each package in phabricator and looking at their package.yml?

14

Will change this.

28

It's a readme file(with the contents 'readme') and some other debian packaging leftovers.

eyecreate updated this revision to Diff 20820.Apr 14 2020, 2:03 PM

Fixed some dependecies being wrong.

DataDrake accepted this revision.Apr 15 2020, 4:44 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Apr 15 2020, 4:44 AM